feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Update comparison of WOLFSSL_BN_ULONG value to MP_MASK to include check for potential type size differences which can lead to pointless-comparison warnings with IAR tools

Browse Source
This commit is contained in:
tim-weller-wolfssl
2022-12-27 14:16:34 -06:00
parent adb406e1ee
commit 2c2740d0dc
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/ssl.c
View File

@ -35907,7 +35907,8 @@ int wolfSSL_BN_is_word(const WOLFSSL_BIGNUM* bn, WOLFSSL_BN_ULONG w)
return WOLFSSL_FAILURE; return WOLFSSL_FAILURE;
} }
if (w <= (WOLFSSL_BN_ULONG)MP_MASK) { /* Check operand sizes before value check to avoid pointless comparison */
if ((sizeof(w) <= sizeof(MP_MASK)) || (w <= (WOLFSSL_BN_ULONG)MP_MASK)) {
if (mp_isword((mp_int*)bn->internal, (mp_digit)w) == MP_YES) { if (mp_isword((mp_int*)bn->internal, (mp_digit)w) == MP_YES) {
return WOLFSSL_SUCCESS; return WOLFSSL_SUCCESS;
} }
@ -36565,7 +36566,8 @@ static int wolfSSL_BN_add_word_int(WOLFSSL_BIGNUM *bn, WOLFSSL_BN_ULONG w,
} }
if (ret == WOLFSSL_SUCCESS) { if (ret == WOLFSSL_SUCCESS) {
if (w <= (WOLFSSL_BN_ULONG)MP_MASK) { /* Check operand sizes before value check to avoid pointless comparison */
if ((sizeof(w) <= sizeof(MP_MASK)) || (w <= (WOLFSSL_BN_ULONG)MP_MASK)) {
if (sub == 1) { if (sub == 1) {
rc = mp_sub_d((mp_int*)bn->internal, (mp_digit)w, rc = mp_sub_d((mp_int*)bn->internal, (mp_digit)w,
(mp_int*)bn->internal); (mp_int*)bn->internal);
@ -36877,7 +36879,8 @@ WOLFSSL_BN_ULONG wolfSSL_BN_mod_word(const WOLFSSL_BIGNUM *bn,
return (WOLFSSL_BN_ULONG)WOLFSSL_FATAL_ERROR; return (WOLFSSL_BN_ULONG)WOLFSSL_FATAL_ERROR;
} }
if (w <= (WOLFSSL_BN_ULONG)MP_MASK) { /* Check operand sizes before value check to avoid pointless comparison */
if ((sizeof(w) <= sizeof(MP_MASK)) || (w <= (WOLFSSL_BN_ULONG)MP_MASK)) {
mp_digit bn_ret; mp_digit bn_ret;
if (mp_mod_d((mp_int*)bn->internal, (mp_digit)w, &bn_ret) != MP_OKAY) { if (mp_mod_d((mp_int*)bn->internal, (mp_digit)w, &bn_ret) != MP_OKAY) {
WOLFSSL_MSG("mp_add_d error"); WOLFSSL_MSG("mp_add_d error");