feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

add additional STM32 ECC sanity check to sign

Browse Source
This commit is contained in:
Jacob Barthelmeh
2023-06-06 12:09:41 -06:00
committed by JacobBarthelmeh
parent 2a0b244393
commit 327645ff2a
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
wolfcrypt/src/port/st/stm32.c
View File

@ -992,7 +992,7 @@ int stm32_ecc_verify_hash_ex(mp_int *r, mp_int *s, const byte* hash,
else if (hashlen > size) { else if (hashlen > size) {
/* in the case that hashlen is larger than key size place hash at /* in the case that hashlen is larger than key size place hash at
* beginning of buffer */ * beginning of buffer */
XMEMCPY(Hashbin, hash, hashlen); XMEMCPY(Hashbin, hash, size);
} }
else { else {
/* in all other cases where hashlen is equal to or less than the key /* in all other cases where hashlen is equal to or less than the key
@ -1072,7 +1072,19 @@ int stm32_ecc_sign_hash_ex(const byte* hash, word32 hashlen, WC_RNG* rng,
pka_ecc.primeOrder = order; pka_ecc.primeOrder = order;
XMEMSET(Hashbin, 0, STM32_MAX_ECC_SIZE); XMEMSET(Hashbin, 0, STM32_MAX_ECC_SIZE);
XMEMCPY(Hashbin + (size - hashlen), hash, hashlen); if (hashlen > STM32_MAX_ECC_SIZE) {
return ECC_BAD_ARG_E;
}
else if (hashlen > size) {
/* in the case that hashlen is larger than key size place hash at
* beginning of buffer */
XMEMCPY(Hashbin, hash, size);
}
else {
/* in all other cases where hashlen is equal to or less than the key
* size pad the Hashbin buffer with leading zero's */
XMEMCPY(Hashbin + (size - hashlen), hash, hashlen);
}
pka_ecc.hash = Hashbin; pka_ecc.hash = Hashbin;
pka_ecc.integer = Intbin; pka_ecc.integer = Intbin;
pka_ecc.privateKey = Keybin; pka_ecc.privateKey = Keybin;