feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Fix PEM_write_bio_X509 to work with new BIO code

Browse Source
This commit is contained in:
Sean Parkinson
2018-03-15 10:45:49 +10:00
parent 717ba83deb
commit 3f99a2a391
1 changed files with 24 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
src/ssl.c
View File

@ -31033,50 +31033,45 @@ int wolfSSL_PEM_write_bio_X509_AUX(WOLFSSL_BIO *bp, WOLFSSL_X509 *x)
int wolfSSL_PEM_write_bio_X509(WOLFSSL_BIO *bio, WOLFSSL_X509 *cert) int wolfSSL_PEM_write_bio_X509(WOLFSSL_BIO *bio, WOLFSSL_X509 *cert)
{ {
byte* certDer; byte* pem;
int pemSz = 0;
const unsigned char* der;
int derSz; int derSz;
int pemSz;
int ret; int ret;
WOLFSSL_ENTER("wolfSSL_PEM_write_bio_X509"); WOLFSSL_ENTER("wolfSSL_PEM_write_bio_X509_AUX()");
if (bio == NULL || cert == NULL) { if (bio == NULL || cert == NULL) {
WOLFSSL_MSG("NULL argument passed in");
return WOLFSSL_FAILURE; return WOLFSSL_FAILURE;
} }
if (bio->type != WOLFSSL_BIO_MEMORY) { der = wolfSSL_X509_get_der(cert, &derSz);
WOLFSSL_MSG("BIO type not supported for writing X509 as PEM"); if (der == NULL) {
return WOLFSSL_FAILURE; return WOLFSSL_FAILURE;
} }
certDer = cert->derCert->buffer; /* get PEM size */
derSz = cert->derCert->length; pemSz = wc_DerToPemEx(der, derSz, NULL, 0, NULL, CERT_TYPE);
/* Get PEM encoded length and allocate memory for it. */
pemSz = wc_DerToPem(certDer, derSz, NULL, 0, CERT_TYPE);
if (pemSz < 0) { if (pemSz < 0) {
WOLFSSL_LEAVE("wolfSSL_PEM_write_bio_X509", pemSz);
return WOLFSSL_FAILURE;
}
if (bio->mem != NULL) {
XFREE(bio->mem, NULL, DYNAMIC_TYPE_OPENSSL);
}
bio->mem = (byte*)XMALLOC(pemSz, NULL, DYNAMIC_TYPE_OPENSSL);
if (bio->mem == NULL) {
return WOLFSSL_FAILURE;
}
bio->memLen = pemSz;
if (bio->mem_buf != NULL) {
bio->mem_buf->data = (char*)bio->mem;
bio->mem_buf->length = bio->memLen;
}
ret = wc_DerToPemEx(certDer, derSz, bio->mem, bio->memLen, NULL, CERT_TYPE);
if (ret < 0) {
WOLFSSL_LEAVE("wolfSSL_PEM_write_bio_X509", ret);
return WOLFSSL_FAILURE; return WOLFSSL_FAILURE;
} }
/* create PEM buffer and convert from DER */
pem = (byte*)XMALLOC(pemSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
if (pem == NULL) {
return WOLFSSL_FAILURE;
}
if (wc_DerToPemEx(der, derSz, pem, pemSz, NULL, CERT_TYPE) < 0) {
XFREE(pem, NULL, DYNAMIC_TYPE_TMP_BUFFER);
return WOLFSSL_FAILURE;
}
/* write the PEM to BIO */
ret = wolfSSL_BIO_write(bio, pem, pemSz);
XFREE(pem, NULL, DYNAMIC_TYPE_TMP_BUFFER);
if (ret <= 0) return WOLFSSL_FAILURE;
return WOLFSSL_SUCCESS; return WOLFSSL_SUCCESS;
} }