feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

SP rand_prime: fix length check

Browse Source 
-ve length indicates to use a BBS prime (last two bits set)
This commit is contained in:
Sean Parkinson
2021-01-04 12:31:59 +10:00
parent ef56bc09f1
commit 40ab08be45
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wolfcrypt/src/sp_int.c
View File

@@ -12989,13 +12989,11 @@ int sp_rand_prime(sp_int* r, int len, WC_RNG* rng, void* heap)
(void)heap; (void)heap;
if ((r == NULL) || (rng == NULL) || len < 0 ) { /* Check NULL parameters and 0 is not prime so 0 bytes is invalid. */
if ((r == NULL) || (rng == NULL) || (len == 0)) {
err = MP_VAL; err = MP_VAL;
} }
if (len == 0)
return MP_OKAY;
if (err == MP_OKAY) { if (err == MP_OKAY) {
/* get type */ /* get type */
if (len < 0) { if (len < 0) {

3
wolfcrypt/test/test.c
View File

@@ -30786,6 +30786,9 @@ static int mp_test_param(mp_int* a, mp_int* b, mp_int* r, WC_RNG* rng)
ret = mp_rand_prime(NULL, 32, rng, NULL); ret = mp_rand_prime(NULL, 32, rng, NULL);
if (ret != MP_VAL) if (ret != MP_VAL)
return -12789; return -12789;
ret = mp_rand_prime(a, 0, rng, NULL);
if (ret != MP_VAL)
return -9969;
#endif #endif
#if defined(WOLFSSL_SP_MATH_ALL) && !defined(WOLFSSL_RSA_VERIFY_ONLY) #if defined(WOLFSSL_SP_MATH_ALL) && !defined(WOLFSSL_RSA_VERIFY_ONLY)