feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Fix output length bug in SP non-blocking ECC shared secret gen.

Browse Source 
This was incorrectly being set to 32 for P-384/521 due to a bug in the SP gen
script.
This commit is contained in:
Hayden Roche
2022-10-13 16:18:20 -07:00
parent 757549dd1b
commit 40f1ba7e33
7 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wolfcrypt/src/sp_arm32.c
View File

@ -92096,7 +92096,7 @@ int sp_ecc_secret_gen_384_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_384_to_bin_12(ctx->point.x, out); sp_384_to_bin_12(ctx->point.x, out);
*outLen = 32; *outLen = 48;
} }
break; break;
} }
@ -119525,7 +119525,7 @@ int sp_ecc_secret_gen_521_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_521_to_bin_17(ctx->point.x, out); sp_521_to_bin_17(ctx->point.x, out);
*outLen = 32; *outLen = 66;
} }
break; break;
} }

4
wolfcrypt/src/sp_arm64.c
View File

@ -65863,7 +65863,7 @@ int sp_ecc_secret_gen_384_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_384_to_bin_6(ctx->point.x, out); sp_384_to_bin_6(ctx->point.x, out);
*outLen = 32; *outLen = 48;
} }
break; break;
} }
@ -110869,7 +110869,7 @@ int sp_ecc_secret_gen_521_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_521_to_bin_9(ctx->point.x, out); sp_521_to_bin_9(ctx->point.x, out);
*outLen = 32; *outLen = 66;
} }
break; break;
} }

4
wolfcrypt/src/sp_armthumb.c
View File

@ -115081,7 +115081,7 @@ int sp_ecc_secret_gen_384_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_384_to_bin_12(ctx->point.x, out); sp_384_to_bin_12(ctx->point.x, out);
*outLen = 32; *outLen = 48;
} }
break; break;
} }
@ -129544,7 +129544,7 @@ int sp_ecc_secret_gen_521_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_521_to_bin_17(ctx->point.x, out); sp_521_to_bin_17(ctx->point.x, out);
*outLen = 32; *outLen = 66;
} }
break; break;
} }

4
wolfcrypt/src/sp_c32.c
View File

@ -33221,7 +33221,7 @@ int sp_ecc_secret_gen_384_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_384_to_bin_15(ctx->point.x, out); sp_384_to_bin_15(ctx->point.x, out);
*outLen = 32; *outLen = 48;
} }
break; break;
} }
@ -41321,7 +41321,7 @@ int sp_ecc_secret_gen_521_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_521_to_bin_21(ctx->point.x, out); sp_521_to_bin_21(ctx->point.x, out);
*outLen = 32; *outLen = 66;
} }
break; break;
} }

4
wolfcrypt/src/sp_c64.c
View File

@ -33569,7 +33569,7 @@ int sp_ecc_secret_gen_384_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_384_to_bin_7(ctx->point.x, out); sp_384_to_bin_7(ctx->point.x, out);
*outLen = 32; *outLen = 48;
} }
break; break;
} }
@ -40989,7 +40989,7 @@ int sp_ecc_secret_gen_521_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_521_to_bin_9(ctx->point.x, out); sp_521_to_bin_9(ctx->point.x, out);
*outLen = 32; *outLen = 66;
} }
break; break;
} }

4
wolfcrypt/src/sp_cortexm.c
View File

@ -30337,7 +30337,7 @@ int sp_ecc_secret_gen_384_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_384_to_bin_12(ctx->point.x, out); sp_384_to_bin_12(ctx->point.x, out);
*outLen = 32; *outLen = 48;
} }
break; break;
} }
@ -38801,7 +38801,7 @@ int sp_ecc_secret_gen_521_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_521_to_bin_17(ctx->point.x, out); sp_521_to_bin_17(ctx->point.x, out);
*outLen = 32; *outLen = 66;
} }
break; break;
} }

4
wolfcrypt/src/sp_x86_64.c
View File

@ -49849,7 +49849,7 @@ int sp_ecc_secret_gen_384_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_384_to_bin_6(ctx->point.x, out); sp_384_to_bin_6(ctx->point.x, out);
*outLen = 32; *outLen = 48;
} }
break; break;
} }
@ -90894,7 +90894,7 @@ int sp_ecc_secret_gen_521_nb(sp_ecc_ctx_t* sp_ctx, const mp_int* priv,
&ctx->point, &ctx->point, ctx->k, 1, 1, heap); &ctx->point, &ctx->point, ctx->k, 1, 1, heap);
if (err == MP_OKAY) { if (err == MP_OKAY) {
sp_521_to_bin_9(ctx->point.x, out); sp_521_to_bin_9(ctx->point.x, out);
*outLen = 32; *outLen = 66;
} }
break; break;
} }