feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Merge pull request #4534 from JacobBarthelmeh/fuzzing

Browse Source 
check size of values with sp_gcd
This commit is contained in:
Sean Parkinson
2021-11-09 08:40:21 +10:00
committed by GitHub
parent 4453001fac ca72beb688
commit 49024b131e
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wolfcrypt/src/sp_int.c
View File

@ -13450,7 +13450,7 @@ int sp_prime_is_prime_ex(sp_int* a, int t, int* result, WC_RNG* rng)
* @param [out] r SP integer to hold result. * @param [out] r SP integer to hold result.
* *
* @return MP_OKAY on success. * @return MP_OKAY on success.
* @return MP_VAL when a, b or r is NULL. * @return MP_VAL when a, b or r is NULL or too large.
* @return MP_MEM when dynamic memory allocation fails. * @return MP_MEM when dynamic memory allocation fails.
*/ */
int sp_gcd(sp_int* a, sp_int* b, sp_int* r) int sp_gcd(sp_int* a, sp_int* b, sp_int* r)
@ -13460,6 +13460,9 @@ int sp_gcd(sp_int* a, sp_int* b, sp_int* r)
if ((a == NULL) || (b == NULL) || (r == NULL)) { if ((a == NULL) || (b == NULL) || (r == NULL)) {
err = MP_VAL; err = MP_VAL;
} }
else if (a->used >= SP_INT_DIGITS || b->used >= SP_INT_DIGITS) {
err = MP_VAL;
}
else if (sp_iszero(a)) { else if (sp_iszero(a)) {
/* GCD of 0 and 0 is undefined as all integers divide 0. */ /* GCD of 0 and 0 is undefined as all integers divide 0. */
if (sp_iszero(b)) { if (sp_iszero(b)) {
@ -13482,6 +13485,7 @@ int sp_gcd(sp_int* a, sp_int* b, sp_int* r)
SAVE_VECTOR_REGISTERS(err = _svr_ret;); SAVE_VECTOR_REGISTERS(err = _svr_ret;);
ALLOC_SP_INT_ARRAY(d, used, 3, err, NULL); ALLOC_SP_INT_ARRAY(d, used, 3, err, NULL);
if (err == MP_OKAY) { if (err == MP_OKAY) {
u = d[0]; u = d[0];
v = d[1]; v = d[1];