forked from wolfSSL/wolfssl
Reviewer feedback
This commit is contained in:
@ -5023,7 +5023,6 @@ typedef struct Dsh13Args {
|
|||||||
int DoTls13ServerHello(WOLFSSL* ssl, const byte* input, word32* inOutIdx,
|
int DoTls13ServerHello(WOLFSSL* ssl, const byte* input, word32* inOutIdx,
|
||||||
word32 helloSz, byte* extMsgType)
|
word32 helloSz, byte* extMsgType)
|
||||||
{
|
{
|
||||||
word32 inOutIdxCopy;
|
|
||||||
int ret;
|
int ret;
|
||||||
byte suite[2];
|
byte suite[2];
|
||||||
byte tls12minor;
|
byte tls12minor;
|
||||||
@ -5356,8 +5355,9 @@ int DoTls13ServerHello(WOLFSSL* ssl, const byte* input, word32* inOutIdx,
|
|||||||
DtlsCIDOnExtensionsParsed(ssl);
|
DtlsCIDOnExtensionsParsed(ssl);
|
||||||
#endif /* WOLFSSL_DTLS_CID */
|
#endif /* WOLFSSL_DTLS_CID */
|
||||||
|
|
||||||
inOutIdxCopy = *inOutIdx;
|
if (IsAtLeastTLSv1_3(ssl->version)) {
|
||||||
*inOutIdx = args->idx;
|
*inOutIdx = args->idx;
|
||||||
|
}
|
||||||
|
|
||||||
ssl->options.serverState = SERVER_HELLO_COMPLETE;
|
ssl->options.serverState = SERVER_HELLO_COMPLETE;
|
||||||
|
|
||||||
@ -5401,9 +5401,8 @@ int DoTls13ServerHello(WOLFSSL* ssl, const byte* input, word32* inOutIdx,
|
|||||||
else
|
else
|
||||||
ssl->chVersion.minor = TLSv1_2_MINOR;
|
ssl->chVersion.minor = TLSv1_2_MINOR;
|
||||||
/* Complete TLS v1.2 processing of ServerHello. */
|
/* Complete TLS v1.2 processing of ServerHello. */
|
||||||
ret = DoServerHello(ssl, input, &inOutIdxCopy, helloSz);
|
ret = DoServerHello(ssl, input, inOutIdx, helloSz);
|
||||||
#else
|
#else
|
||||||
(void)inOutIdxCopy;
|
|
||||||
WOLFSSL_MSG("Client using higher version, fatal error");
|
WOLFSSL_MSG("Client using higher version, fatal error");
|
||||||
WOLFSSL_ERROR_VERBOSE(VERSION_ERROR);
|
WOLFSSL_ERROR_VERBOSE(VERSION_ERROR);
|
||||||
ret = VERSION_ERROR;
|
ret = VERSION_ERROR;
|
||||||
|
Reference in New Issue
Block a user