feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Merge pull request #8319 from philljj/fix_coverity

Browse Source 
coverity: correct lock message, check fd value.
This commit is contained in:
David Garske
2024-12-26 12:53:36 -08:00
committed by GitHub
parent f57f044b39 c71392bb7e
commit 5c6fdb52f1
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/crl.c
View File

@ -1102,7 +1102,7 @@ int wolfSSL_X509_STORE_add_crl(WOLFSSL_X509_STORE *store, WOLFSSL_X509_CRL *newc
} }
if (crl != newcrl && wc_LockRwLock_Rd(&newcrl->crlLock) != 0) { if (crl != newcrl && wc_LockRwLock_Rd(&newcrl->crlLock) != 0) {
WOLFSSL_MSG("wc_LockRwLock_Wr failed"); WOLFSSL_MSG("wc_LockRwLock_Rd failed");
wc_UnLockRwLock(&crl->crlLock); wc_UnLockRwLock(&crl->crlLock);
return BAD_MUTEX_E; return BAD_MUTEX_E;
} }

3
tests/api.c
View File

@ -90321,6 +90321,7 @@ static void test_wolfSSL_dtls_plaintext_client(WOLFSSL* ssl)
byte msg[] = "This is a msg for the server"; byte msg[] = "This is a msg for the server";
byte reply[40]; byte reply[40];
AssertIntGE(fd, 0);
generateDTLSMsg(ch, sizeof(ch), 20, client_hello, 0); generateDTLSMsg(ch, sizeof(ch), 20, client_hello, 0);
/* Server should ignore this datagram */ /* Server should ignore this datagram */
AssertIntEQ(send(fd, ch, sizeof(ch), 0), sizeof(ch)); AssertIntEQ(send(fd, ch, sizeof(ch), 0), sizeof(ch));
@ -90555,6 +90556,7 @@ static void test_wolfSSL_dtls_send_alert(WOLFSSL* ssl)
}; };
fd = wolfSSL_get_wfd(ssl); fd = wolfSSL_get_wfd(ssl);
AssertIntGE(fd, 0);
ret = (int)send(fd, alert_msg, sizeof(alert_msg), 0); ret = (int)send(fd, alert_msg, sizeof(alert_msg), 0);
AssertIntGT(ret, 0); AssertIntGT(ret, 0);
} }
@ -90952,6 +90954,7 @@ static void test_wolfSSL_dtls_send_ch(WOLFSSL* ssl)
}; };
fd = wolfSSL_get_wfd(ssl); fd = wolfSSL_get_wfd(ssl);
AssertIntGE(fd, 0);
ret = (int)send(fd, ch_msg, sizeof(ch_msg), 0); ret = (int)send(fd, ch_msg, sizeof(ch_msg), 0);
AssertIntGT(ret, 0); AssertIntGT(ret, 0);
/* consume the HRR otherwise handshake will fail */ /* consume the HRR otherwise handshake will fail */