Review comments, sanity check

This commit is contained in:
Tesfa Mael
2019-08-27 17:06:36 -07:00
parent 59dddda3a9
commit 625c3074b9

View File

@@ -13791,6 +13791,9 @@ int wolfSSL_EVP_MD_type(const WOLFSSL_EVP_MD *md)
int arg, void *ptr) int arg, void *ptr)
{ {
int ret = WOLFSSL_FAILURE; int ret = WOLFSSL_FAILURE;
if (ctx == NULL)
return WOLFSSL_FAILURE;
(void)arg; (void)arg;
(void)ptr; (void)ptr;
@@ -13812,7 +13815,7 @@ int wolfSSL_EVP_MD_type(const WOLFSSL_EVP_MD *md)
ret = wolfSSL_EVP_CIPHER_CTX_set_iv_length(ctx, arg); ret = wolfSSL_EVP_CIPHER_CTX_set_iv_length(ctx, arg);
break; break;
case EVP_CTRL_AEAD_SET_TAG: case EVP_CTRL_AEAD_SET_TAG:
if(arg <= 0 || arg > 16) if(arg <= 0 || arg > 16 || (ptr == NULL))
return WOLFSSL_FAILURE; return WOLFSSL_FAILURE;
XMEMCPY(ctx->authTag, ptr, arg); XMEMCPY(ctx->authTag, ptr, arg);
@@ -14356,6 +14359,7 @@ int wolfSSL_EVP_MD_type(const WOLFSSL_EVP_MD *md)
return WOLFSSL_SUCCESS; return WOLFSSL_SUCCESS;
} }
#if defined(HAVE_AESGCM) #if defined(HAVE_AESGCM)
/* returns WOLFSSL_SUCCESS on success, otherwise returns WOLFSSL_FAILURE */
int wolfSSL_EVP_CIPHER_CTX_set_iv_length(WOLFSSL_EVP_CIPHER_CTX* ctx, int wolfSSL_EVP_CIPHER_CTX_set_iv_length(WOLFSSL_EVP_CIPHER_CTX* ctx,
int ivLen) int ivLen)
{ {
@@ -30542,7 +30546,7 @@ int wolfSSL_RSA_print(WOLFSSL_BIO* bio, WOLFSSL_RSA* rsa, int offset)
return WOLFSSL_FAILURE; return WOLFSSL_FAILURE;
} }
for (i=0; i<8; i++) { for (i=0; i<RSA_INTS; i++) {
switch(i) { switch(i) {
case 0: case 0:
/* Print out modulus */ /* Print out modulus */