feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

ssl: refactoring CyaSSL_BN_hex2bn to reduce stack usage:

Browse Source 
--- variable decoded moved to the heap (1024 bytes saved)
This commit is contained in:
Moisés Guimarães
2014-09-15 16:44:27 -03:00
parent 4b783b3d80
commit 68063874dc
1 changed files with 29 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
src/ssl.c
View File

@@ -10272,38 +10272,45 @@ int CyaSSL_BN_is_bit_set(const CYASSL_BIGNUM* bn, int n)
/* SSL_SUCCESS on ok */ /* SSL_SUCCESS on ok */
int CyaSSL_BN_hex2bn(CYASSL_BIGNUM** bn, const char* str) int CyaSSL_BN_hex2bn(CYASSL_BIGNUM** bn, const char* str)
{ {
byte decoded[1024]; int ret = 0;
word32 decSz = sizeof(decoded); word32 decSz = 1024;
#ifdef CYASSL_SMALL_STACK
byte* decoded = NULL;
#else
byte decoded[1024];
#endif
CYASSL_MSG("CyaSSL_BN_hex2bn"); CYASSL_MSG("CyaSSL_BN_hex2bn");
if (str == NULL) { #ifdef CYASSL_SMALL_STACK
decoded = (byte*)XMALLOC(decSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
if (decoded == NULL)
return 0;
#endif
if (str == NULL)
CYASSL_MSG("Bad function argument"); CYASSL_MSG("Bad function argument");
return 0; else if (Base16_Decode((byte*)str, (int)XSTRLEN(str), decoded, &decSz) < 0)
}
if (Base16_Decode((byte*)str, (int)XSTRLEN(str), decoded, &decSz) < 0) {
CYASSL_MSG("Bad Base16_Decode error"); CYASSL_MSG("Bad Base16_Decode error");
return 0; else if (bn == NULL)
} ret = decSz;
else {
if (*bn == NULL)
*bn = CyaSSL_BN_new();
if (bn == NULL) if (*bn == NULL)
return decSz;
if (*bn == NULL) {
*bn = CyaSSL_BN_new();
if (*bn == NULL) {
CYASSL_MSG("BN new failed"); CYASSL_MSG("BN new failed");
return 0; else if (CyaSSL_BN_bin2bn(decoded, decSz, *bn) == NULL)
} CYASSL_MSG("Bad bin2bn error");
else
ret = SSL_SUCCESS;
} }
if (CyaSSL_BN_bin2bn(decoded, decSz, *bn) == NULL) { #ifdef CYASSL_SMALL_STACK
CYASSL_MSG("Bad bin2bn error"); XFREE(decoded, NULL, DYNAMIC_TYPE_TMP_BUFFER);
return 0; #endif
}
return SSL_SUCCESS; return ret;
} }