feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Merge pull request #8085 from philljj/fix_coverity

Browse Source 
Fix coverity errors
This commit is contained in:
Daniel Pouzzner
2024-10-16 17:18:31 -05:00
committed by GitHub
parent cc421ddace 554ebc2e9e
commit 8803f3dd70
3 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/ssl_asn1.c
View File

@ -282,7 +282,7 @@ static int wolfssl_i2d_asn1_items(const void* obj, byte* buf,
len = 0; len = 0;
break; break;
} }
if (buf != NULL && !mem->ex && mem->tag >= 0) { if (buf != NULL && tmp != NULL && !mem->ex && mem->tag >= 0) {
/* Encode the implicit tag */ /* Encode the implicit tag */
byte imp[ASN_TAG_SZ + MAX_LENGTH_SZ]; byte imp[ASN_TAG_SZ + MAX_LENGTH_SZ];
SetImplicit(tmp[0], mem->tag, 0, imp, 0); SetImplicit(tmp[0], mem->tag, 0, imp, 0);

8
wolfcrypt/src/pkcs7.c
View File

@ -13698,6 +13698,7 @@ authenv_atrbend:
/* free memory, zero out keys */ /* free memory, zero out keys */
ForceZero(encryptedContent, (word32)encryptedContentSz); ForceZero(encryptedContent, (word32)encryptedContentSz);
XFREE(encryptedContent, pkcs7->heap, DYNAMIC_TYPE_PKCS7); XFREE(encryptedContent, pkcs7->heap, DYNAMIC_TYPE_PKCS7);
encryptedContent = NULL;
ForceZero(decryptedKey, MAX_ENCRYPTED_KEY_SZ); ForceZero(decryptedKey, MAX_ENCRYPTED_KEY_SZ);
#ifdef WOLFSSL_SMALL_STACK #ifdef WOLFSSL_SMALL_STACK
XFREE(decryptedKey, pkcs7->heap, DYNAMIC_TYPE_PKCS7); XFREE(decryptedKey, pkcs7->heap, DYNAMIC_TYPE_PKCS7);
@ -13726,8 +13727,11 @@ authenv_atrbend:
} }
#else #else
if (ret < 0) { if (ret < 0) {
ForceZero(encryptedContent, (word32)encryptedContentSz); if (encryptedContent != NULL) {
XFREE(encryptedContent, pkcs7->heap, DYNAMIC_TYPE_PKCS7); ForceZero(encryptedContent, (word32)encryptedContentSz);
XFREE(encryptedContent, pkcs7->heap, DYNAMIC_TYPE_PKCS7);
encryptedContent = NULL;
}
ForceZero(decryptedKey, MAX_ENCRYPTED_KEY_SZ); ForceZero(decryptedKey, MAX_ENCRYPTED_KEY_SZ);
} }
#endif #endif

14
wolfcrypt/test/test.c
View File

@ -56315,16 +56315,24 @@ static wc_test_ret_t mp_test_mont(mp_int* a, mp_int* m, mp_int* n, mp_int* r, WC
/* a = 2^(bits*2) - 1 */ /* a = 2^(bits*2) - 1 */
mp_zero(a); mp_zero(a);
mp_set_bit(a, bits[i] * 2); mp_set_bit(a, bits[i] * 2);
mp_sub_d(a, 1, a); ret = mp_sub_d(a, 1, a);
if (ret != MP_OKAY)
return WC_TEST_RET_ENC_EC(ret);
/* m = 2^(bits) - 1 */ /* m = 2^(bits) - 1 */
mp_zero(m); mp_zero(m);
mp_set_bit(m, bits[i]); mp_set_bit(m, bits[i]);
mp_sub_d(m, 1, m); ret = mp_sub_d(m, 1, m);
if (ret != MP_OKAY)
return WC_TEST_RET_ENC_EC(ret);
mp = 1; mp = 1;
/* result = r = 2^(bits) - 1 */ /* result = r = 2^(bits) - 1 */
mp_zero(r); mp_zero(r);
mp_set_bit(r, bits[i]); mp_set_bit(r, bits[i]);
mp_sub_d(r, 1, r); ret = mp_sub_d(r, 1, r);
if (ret != MP_OKAY)
return WC_TEST_RET_ENC_EC(ret);
ret = mp_montgomery_reduce(a, m, mp); ret = mp_montgomery_reduce(a, m, mp);
if (ret != MP_OKAY) if (ret != MP_OKAY)