feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Merge pull request #2602 from SparkiDev/certs_exts_free

Browse Source 
ProcessPeerCerts jump to error handling instead of returning
This commit is contained in:
toddouska
2019-11-20 09:25:48 -08:00
committed by GitHub
parent 2a7fb69523 1b8f136d29
commit 88fb7efb8c
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/internal.c
View File

@@ -10047,12 +10047,14 @@ int ProcessPeerCerts(WOLFSSL* ssl, byte* input, word32* inOutIdx,
if (ssl->options.tls1_3) { if (ssl->options.tls1_3) {
word16 extSz; word16 extSz;
if ((args->idx - args->begin) + OPAQUE16_LEN > totalSz) if ((args->idx - args->begin) + OPAQUE16_LEN > totalSz) {
return BUFFER_ERROR; ERROR_OUT(BUFFER_ERROR, exit_ppc);
}
ato16(input + args->idx, &extSz); ato16(input + args->idx, &extSz);
args->idx += OPAQUE16_LEN; args->idx += OPAQUE16_LEN;
if ((args->idx - args->begin) + extSz > totalSz) if ((args->idx - args->begin) + extSz > totalSz) {
return BUFFER_ERROR; ERROR_OUT(BUFFER_ERROR, exit_ppc);
}
/* Store extension data info for later processing. */ /* Store extension data info for later processing. */
args->exts[args->totalCerts].length = extSz; args->exts[args->totalCerts].length = extSz;
args->exts[args->totalCerts].buffer = input + args->idx; args->exts[args->totalCerts].buffer = input + args->idx;
@@ -10060,8 +10062,9 @@ int ProcessPeerCerts(WOLFSSL* ssl, byte* input, word32* inOutIdx,
listSz -= extSz + OPAQUE16_LEN; listSz -= extSz + OPAQUE16_LEN;
ret = TLSX_Parse(ssl, args->exts[args->totalCerts].buffer, ret = TLSX_Parse(ssl, args->exts[args->totalCerts].buffer,
args->exts[args->totalCerts].length, certificate, NULL); args->exts[args->totalCerts].length, certificate, NULL);
if (ret < 0) if (ret < 0) {
return ret; ERROR_OUT(ret, exit_ppc);
}
} }
#endif #endif