From 7674a24972ef7fe51bdb92a9a102362d51f4f844 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Moise=CC=81s=20Guimara=CC=83es?= <moises@wolfssl.com>
Date: Tue, 7 Nov 2017 10:39:55 -0300
Subject: [PATCH 1/2] removes unreachable code with a single return point

---
 src/tls.c | 36 +++++++++++++++++++++---------------
 1 file changed, 21 insertions(+), 15 deletions(-)

diff --git a/src/tls.c b/src/tls.c
index c1c50c986..4c77b2115 100644
--- a/src/tls.c
+++ b/src/tls.c
@@ -2881,38 +2881,44 @@ static void TLSX_PointFormat_FreeAll(PointFormat* list, void* heap)
 static int TLSX_SupportedCurve_Append(SupportedCurve* list, word16 name,
                                                                      void* heap)
 {
-    if (list == NULL)
-        return BAD_FUNC_ARG;
+    int ret = BAD_FUNC_ARG;
 
-    while (1) {
-        if (list->name == name)
-            return 0; /* curve alreay in use */
+    while (list) {
+        if (list->name == name) {
+            ret = 0; /* curve alreay in use */
+            break;
+        }
 
-        if (list->next == NULL)
-            return TLSX_SupportedCurve_New(&list->next, name, heap);
+        if (list->next == NULL) {
+            ret = TLSX_SupportedCurve_New(&list->next, name, heap);
+            break;
+        }
 
         list = list->next;
     }
 
-    return 0;
+    return ret;
 }
 
 static int TLSX_PointFormat_Append(PointFormat* list, byte format, void* heap)
 {
-    if (list == NULL)
-        return BAD_FUNC_ARG;
+    int ret = BAD_FUNC_ARG;
 
     while (1) {
-        if (list->format == format)
-            return 0; /* format already in use */
+        if (list->format == format) {
+            ret = 0; /* format already in use */
+            break;
+        }
 
-        if (list->next == NULL)
-            return TLSX_PointFormat_New(&list->next, format, heap);
+        if (list->next == NULL) {
+            ret = TLSX_PointFormat_New(&list->next, format, heap);
+            break;
+        }
 
         list = list->next;
     }
 
-    return 0;
+    return ret;
 }
 
 #ifndef NO_WOLFSSL_CLIENT

From 1c19c8847b979b23e3a8043dd959485fb660a8cd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Moise=CC=81s=20Guimara=CC=83es?= <moises@wolfssl.com>
Date: Tue, 7 Nov 2017 10:57:06 -0300
Subject: [PATCH 2/2] fixes while loop

---
 src/tls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tls.c b/src/tls.c
index 4c77b2115..05d77a0ba 100644
--- a/src/tls.c
+++ b/src/tls.c
@@ -2904,7 +2904,7 @@ static int TLSX_PointFormat_Append(PointFormat* list, byte format, void* heap)
 {
     int ret = BAD_FUNC_ARG;
 
-    while (1) {
+    while (list) {
         if (list->format == format) {
             ret = 0; /* format already in use */
             break;