feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

ECC: validate ordinate length before export

Browse Source
This commit is contained in:
Sean Parkinson
2021-07-01 14:50:44 +10:00
parent c820b5679a
commit a992480f91
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
wolfcrypt/src/ecc.c
View File

@ -7605,6 +7605,12 @@ int wc_ecc_export_point_der(const int curve_idx, ecc_point* point, byte* out,
return BUFFER_E; return BUFFER_E;
} }
/* Sanity check the ordinates' sizes. */
if (((word32)mp_unsigned_bin_size(point->x) > numlen) ||
((word32)mp_unsigned_bin_size(point->y) > numlen)) {
return ECC_BAD_ARG_E;
}
/* store byte point type */ /* store byte point type */
out[0] = ECC_POINT_UNCOMP; out[0] = ECC_POINT_UNCOMP;
@ -7676,6 +7682,11 @@ int wc_ecc_export_point_der_compressed(const int curve_idx, ecc_point* point,
return BUFFER_E; return BUFFER_E;
} }
/* Sanity check the ordinate's size. */
if ((word32)mp_unsigned_bin_size(point->x) > numlen) {
return ECC_BAD_ARG_E;
}
/* store byte point type */ /* store byte point type */
out[0] = mp_isodd(point->y) == MP_YES ? ECC_POINT_COMP_ODD : out[0] = mp_isodd(point->y) == MP_YES ? ECC_POINT_COMP_ODD :
ECC_POINT_COMP_EVEN; ECC_POINT_COMP_EVEN;