feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Merge pull request #1596 from dgarske/leakfixes

Browse Source 
Fix for possible leak with normal math and ECC verify fail for R and S
This commit is contained in:
John Safranek
2018-06-04 13:30:09 -07:00
committed by GitHub
parent caf88c81c2 5eca844e01
commit ab5eeb9f79
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
wolfcrypt/src/ecc.c
View File

@@ -4353,6 +4353,13 @@ int wc_ecc_verify_hash(const byte* sig, word32 siglen, const byte* hash,
key->state = ECC_STATE_VERIFY_DO; key->state = ECC_STATE_VERIFY_DO;
err = wc_ecc_verify_hash_ex(r, s, hash, hashlen, res, key); err = wc_ecc_verify_hash_ex(r, s, hash, hashlen, res, key);
#ifndef WOLFSSL_ASYNC_CRYPT
/* done with R/S */
mp_clear(r);
mp_clear(s);
#endif
if (err < 0) { if (err < 0) {
break; break;
} }
@@ -4361,10 +4368,6 @@ int wc_ecc_verify_hash(const byte* sig, word32 siglen, const byte* hash,
case ECC_STATE_VERIFY_RES: case ECC_STATE_VERIFY_RES:
key->state = ECC_STATE_VERIFY_RES; key->state = ECC_STATE_VERIFY_RES;
err = 0; err = 0;
/* done with R/S */
mp_clear(r);
mp_clear(s);
break; break;
default: default: