From cefd55eb740a6b59ab8cd519b9d56c29fbde7612 Mon Sep 17 00:00:00 2001 From: David Garske Date: Wed, 8 Feb 2023 11:25:53 -0800 Subject: [PATCH] Fix for benchmarking shake with custom block size. Using `./benchmark -shake 1024` caused seg fault. --- .gitignore | 4 +++- wolfcrypt/benchmark/benchmark.c | 8 ++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index 7bef3e7c9..ca5861e8a 100644 --- a/.gitignore +++ b/.gitignore @@ -393,6 +393,8 @@ cmake_install.cmake # GDB Settings \.gdbinit +libFuzzer + # Pycharm and other IDEs \.idea @@ -413,4 +415,4 @@ user_settings_asm.h /IDE/Espressif/**/sdkconfig # auto-created CMake backups -**/CMakeLists.txt.old \ No newline at end of file +**/CMakeLists.txt.old diff --git a/wolfcrypt/benchmark/benchmark.c b/wolfcrypt/benchmark/benchmark.c index 1893e7e47..5e7fe6a22 100644 --- a/wolfcrypt/benchmark/benchmark.c +++ b/wolfcrypt/benchmark/benchmark.c @@ -5112,7 +5112,7 @@ void bench_shake128(int useDeviceID) if (bench_async_check(&ret, BENCH_ASYNC_GET_DEV(&hash[i]), 0, ×, numBlocks, &pending)) { ret = wc_Shake128_Update(&hash[i], bench_plain, - BENCH_SIZE); + bench_size); if (!bench_async_handle(&ret, BENCH_ASYNC_GET_DEV(&hash[i]), 0, ×, &pending)) { @@ -5148,7 +5148,7 @@ void bench_shake128(int useDeviceID) ret = wc_InitShake128(hash, HEAP_HINT, useDeviceID ? devId : INVALID_DEVID); if (ret == 0) - ret = wc_Shake128_Update(hash, bench_plain, BENCH_SIZE); + ret = wc_Shake128_Update(hash, bench_plain, bench_size); if (ret == 0) ret = wc_Shake128_Final(hash, digest[0], WC_SHA3_128_BLOCK_SIZE); @@ -5207,7 +5207,7 @@ void bench_shake256(int useDeviceID) if (bench_async_check(&ret, BENCH_ASYNC_GET_DEV(&hash[i]), 0, ×, numBlocks, &pending)) { ret = wc_Shake256_Update(&hash[i], bench_plain, - BENCH_SIZE); + bench_size); if (!bench_async_handle(&ret, BENCH_ASYNC_GET_DEV(&hash[i]), 0, ×, &pending)) { @@ -5243,7 +5243,7 @@ void bench_shake256(int useDeviceID) ret = wc_InitShake256(hash, HEAP_HINT, useDeviceID ? devId : INVALID_DEVID); if (ret == 0) - ret = wc_Shake256_Update(hash, bench_plain, BENCH_SIZE); + ret = wc_Shake256_Update(hash, bench_plain, bench_size); if (ret == 0) ret = wc_Shake256_Final(hash, digest[0], WC_SHA3_256_BLOCK_SIZE);