feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Merge pull request #7257 from philljj/zd17540

Browse Source 
Fix unchecked ge448_scalarmult_base return value.
This commit is contained in:
Sean Parkinson
2024-02-22 07:05:09 +10:00
committed by GitHub
parent 88e7d47930 5aa06c26ff
commit d027b305ab
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
wolfcrypt/src/ed448.c
View File

@ -368,13 +368,15 @@ int wc_ed448_sign_msg_ex(const byte* in, word32 inLen, byte* out,
/* step 2: computing R = rB where rB is the scalar multiplication of /* step 2: computing R = rB where rB is the scalar multiplication of
r and B */ r and B */
ge448_scalarmult_base(&R,nonce); ret = ge448_scalarmult_base(&R,nonce);
ge448_to_bytes(out,&R);
/* step 3: hash R + public key + message getting H(R,A,M) then /* step 3: hash R + public key + message getting H(R,A,M) then
creating S = (r + H(R,A,M)a) mod l */ creating S = (r + H(R,A,M)a) mod l */
if (ret == 0) {
ge448_to_bytes(out,&R);
ret = ed448_hash_update(key, sha, ed448Ctx, ED448CTX_SIZE); ret = ed448_hash_update(key, sha, ed448Ctx, ED448CTX_SIZE);
}
if (ret == 0) { if (ret == 0) {
ret = ed448_hash_update(key, sha, &type, sizeof(type)); ret = ed448_hash_update(key, sha, &type, sizeof(type));
} }