feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

handle sniffer realloc failure w/o leak

Browse Source
This commit is contained in:
toddouska
2015-10-23 16:19:26 -07:00
parent 880ec8cb09
commit d53b6a9132
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sniffer.c
View File

@@ -3077,12 +3077,16 @@ doPart:
ret = ssl->buffers.clearOutputBuffer.length; ret = ssl->buffers.clearOutputBuffer.length;
TraceGotData(ret); TraceGotData(ret);
if (ret) { /* may be blank message */ if (ret) { /* may be blank message */
*data = realloc(*data, decoded + ret); byte* tmpData; /* don't leak on realloc free */
if (*data == NULL) { tmpData = (byte*)realloc(*data, decoded + ret);
if (tmpData == NULL) {
free(*data);
*data = NULL;
SetError(MEMORY_STR, error, session, SetError(MEMORY_STR, error, session,
FATAL_ERROR_STATE); FATAL_ERROR_STATE);
return -1; return -1;
} }
*data = tmpData;
XMEMCPY(*data + decoded, XMEMCPY(*data + decoded,
ssl->buffers.clearOutputBuffer.buffer, ret); ssl->buffers.clearOutputBuffer.buffer, ret);
TraceAddedData(ret, decoded); TraceAddedData(ret, decoded);