From d7e33b329304e9855b7e4b22ad38aef82f415124 Mon Sep 17 00:00:00 2001 From: Daniel Pouzzner Date: Thu, 4 Aug 2022 11:12:09 -0500 Subject: [PATCH] wolfcrypt/src/asn.c: fix null pointer deref in SetReqAttribSingle() (clang-analyzer-core.NonNullParamChecker). --- wolfcrypt/src/asn.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/wolfcrypt/src/asn.c b/wolfcrypt/src/asn.c index aca9132e7..c87589707 100644 --- a/wolfcrypt/src/asn.c +++ b/wolfcrypt/src/asn.c @@ -26227,8 +26227,10 @@ static int SetReqAttribSingle(byte* output, int* idx, char* attr, int attrSz, if (strSz > 0) { XMEMCPY(&output[*idx], str, strSz); *idx += strSz; - XMEMCPY(&output[*idx], attr, attrSz); - *idx += attrSz; + if (attrSz > 0) { + XMEMCPY(&output[*idx], attr, attrSz); + *idx += attrSz; + } } } return totalSz;