From e97f8b5a9cc6c0cdbffa4da214b98299cd68a096 Mon Sep 17 00:00:00 2001 From: Chris Conlon Date: Wed, 20 Dec 2017 12:18:49 -0700 Subject: [PATCH] fix scanbuild issues, internal.c and tfm.c --- src/internal.c | 5 +++++ wolfcrypt/src/tfm.c | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/internal.c b/src/internal.c index d76ace244..0ced00f78 100644 --- a/src/internal.c +++ b/src/internal.c @@ -6022,6 +6022,9 @@ static void AddHandShakeHeader(byte* output, word32 length, /* handshake header */ hs = (HandShakeHeader*)output; + if (hs == NULL) + return; + hs->type = type; c32to24(length, hs->length); /* type and length same for each */ #ifdef WOLFSSL_DTLS @@ -14098,6 +14101,8 @@ int SendAlert(WOLFSSL* ssl, int severity, int type) /* get output buffer */ output = ssl->buffers.outputBuffer.buffer + ssl->buffers.outputBuffer.length; + if (output == NULL) + return BUFFER_E; input[0] = (byte)severity; input[1] = (byte)type; diff --git a/wolfcrypt/src/tfm.c b/wolfcrypt/src/tfm.c index 82169ae1f..81edccd0b 100644 --- a/wolfcrypt/src/tfm.c +++ b/wolfcrypt/src/tfm.c @@ -2915,9 +2915,9 @@ int fp_isprime_ex(fp_int *a, int t) /* do trial division */ for (r = 0; r < FP_PRIME_SIZE; r++) { - fp_mod_d(a, primes[r], &d); - if (d == 0) { - return FP_NO; + res = fp_mod_d(a, primes[r], &d); + if (res != MP_OKAY || d == 0) { + return FP_NO; } }