feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Merge pull request #7880 from ColtonWilley/tls13_send_cert_use_signed_len

Browse Source 
Use signed variable for length calculation in SendTls13Certificate
This commit is contained in:
Daniel Pouzzner
2024-08-29 16:12:41 -05:00
committed by GitHub
parent ef4ea53570 a57d234f6b
commit fab5c9f864
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/tls13.c
View File

@@ -8462,12 +8462,13 @@ static int SendTls13Certificate(WOLFSSL* ssl)
int ret = 0; int ret = 0;
word32 certSz, certChainSz, headerSz, listSz, payloadSz; word32 certSz, certChainSz, headerSz, listSz, payloadSz;
word16 extSz = 0; word16 extSz = 0;
word32 length, maxFragment; word32 maxFragment;
word32 len = 0; word32 len = 0;
word32 idx = 0; word32 idx = 0;
word32 offset = OPAQUE16_LEN; word32 offset = OPAQUE16_LEN;
byte* p = NULL; byte* p = NULL;
byte certReqCtxLen = 0; byte certReqCtxLen = 0;
sword32 length;
#ifdef WOLFSSL_POST_HANDSHAKE_AUTH #ifdef WOLFSSL_POST_HANDSHAKE_AUTH
byte* certReqCtx = NULL; byte* certReqCtx = NULL;
#endif #endif
@@ -8513,7 +8514,7 @@ static int SendTls13Certificate(WOLFSSL* ssl)
listSz = 0; listSz = 0;
} }
else { else {
if (!ssl->buffers.certificate) { if (!ssl->buffers.certificate || !ssl->buffers.certificate->buffer) {
WOLFSSL_MSG("Send Cert missing certificate buffer"); WOLFSSL_MSG("Send Cert missing certificate buffer");
return NO_CERT_ERROR; return NO_CERT_ERROR;
} }
@@ -8604,7 +8605,7 @@ static int SendTls13Certificate(WOLFSSL* ssl)
#endif /* WOLFSSL_DTLS13 */ #endif /* WOLFSSL_DTLS13 */
} }
else { else {
fragSz = min(length, maxFragment); fragSz = min((word32)length, maxFragment);
sendSz += fragSz; sendSz += fragSz;
} }