From 857b382fc34945cdd2ea9b738315aa7b121dbb47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-Micha=C3=ABl=20Celerier?= Date: Wed, 9 May 2018 12:07:20 +0200 Subject: [PATCH] Mark the whole class FormatError as FMT_API Else on windows across DLLs the vtable is not visible which causes linking error --- fmt/format.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fmt/format.h b/fmt/format.h index bcfb7c29..6a234383 100644 --- a/fmt/format.h +++ b/fmt/format.h @@ -710,12 +710,12 @@ typedef BasicCStringRef CStringRef; typedef BasicCStringRef WCStringRef; /** A formatting error such as invalid format string. */ -class FormatError : public std::runtime_error { +class FMT_API FormatError : public std::runtime_error { public: explicit FormatError(CStringRef message) : std::runtime_error(message.c_str()) {} FormatError(const FormatError &ferr) : std::runtime_error(ferr) {} - FMT_API ~FormatError() FMT_DTOR_NOEXCEPT FMT_OVERRIDE; + ~FormatError() FMT_DTOR_NOEXCEPT FMT_OVERRIDE; }; namespace internal {