From 89a8aaf50257a5c0acf067d1af9ecbe647feffc8 Mon Sep 17 00:00:00 2001 From: Victor Zverovich Date: Wed, 30 Apr 2014 11:29:33 -0700 Subject: [PATCH] Fix UB. --- format-test.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/format-test.cc b/format-test.cc index c851f184..9da629a5 100644 --- a/format-test.cc +++ b/format-test.cc @@ -268,9 +268,10 @@ TEST(UtilTest, StrError) { EXPECT_STREQ("", message); result = StrError(error_code, message = buffer, BUFFER_SIZE); EXPECT_EQ(0, result); - EXPECT_GE(BUFFER_SIZE - 1u, std::strlen(message)); + std::size_t message_size = std::strlen(message); + EXPECT_GE(BUFFER_SIZE - 1u, message_size); EXPECT_STREQ(strerror(error_code), message); - result = StrError(error_code, message = buffer, std::strlen(message)); + result = StrError(error_code, message = buffer, message_size); EXPECT_EQ(ERANGE, result); }