fmtlib/fmt
1
0
Fork 1
mirror of https://github.com/fmtlib/fmt.git synced 2025-07-30 10:47:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

use const& for arguments

Browse Source
This commit is contained in:
Alexey Ochapov
2021-02-20 19:08:16 +03:00
committed by Victor Zverovich
parent 29cc8282b1
commit ab0f7d7fdc
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
include/fmt/compile.h
View File

@ -455,7 +455,7 @@ template <typename Char, typename T, int N> struct field {
template <typename OutputIt, typename... Args> template <typename OutputIt, typename... Args>
constexpr OutputIt format(OutputIt out, const Args&... args) const { constexpr OutputIt format(OutputIt out, const Args&... args) const {
if constexpr (is_named_arg<typename std::remove_cv<T>::type>::value) { if constexpr (is_named_arg<typename std::remove_cv<T>::type>::value) {
decltype(T::value) arg = get<N>(args...).value; const auto& arg = get<N>(args...).value;
return write<Char>(out, arg); return write<Char>(out, arg);
} else { } else {
// This ensures that the argument type is convertile to `const T&`. // This ensures that the argument type is convertile to `const T&`.
@ -778,9 +778,9 @@ FMT_INLINE std::basic_string<typename S::char_type> format(const S&,
if constexpr (std::is_same<typename S::char_type, char>::value) { if constexpr (std::is_same<typename S::char_type, char>::value) {
constexpr basic_string_view<typename S::char_type> str = S(); constexpr basic_string_view<typename S::char_type> str = S();
if constexpr (str.size() == 2 && str[0] == '{' && str[1] == '}') { if constexpr (str.size() == 2 && str[0] == '{' && str[1] == '}') {
auto first = detail::first(args...); const auto& first = detail::first(args...);
if constexpr (detail::is_named_arg<typename std::remove_cv< if constexpr (detail::is_named_arg<
decltype(first)>::type>::value) { remove_cvref_t<decltype(first)>>::value) {
return fmt::to_string(first.value); return fmt::to_string(first.value);
} else { } else {
return fmt::to_string(first); return fmt::to_string(first);