fmtlib/fmt
1
0
Fork 1
mirror of https://github.com/fmtlib/fmt.git synced 2025-07-30 10:47:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove some C-style casts for consistency

Browse Source
This commit is contained in:
Junekey Jeon
2022-02-13 03:34:29 -08:00
committed by Victor Zverovich
parent c8bd1e646e
commit b348caa9e9
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
include/fmt/format-inl.h
View File

@ -839,7 +839,8 @@ inline uint128_wrapper umul128(uint64_t x, uint64_t y) noexcept {
result.low_ = _umul128(x, y, &result.high_); result.low_ = _umul128(x, y, &result.high_);
return result; return result;
#else #else
const uint64_t mask = (uint64_t(1) << 32) - uint64_t(1); const uint64_t mask =
static_cast<uint64_t>(std::numeric_limits<uint32_t>::max());
uint64_t a = x >> 32; uint64_t a = x >> 32;
uint64_t b = x & mask; uint64_t b = x & mask;
@ -882,7 +883,7 @@ inline uint128_wrapper umul192_upper128(uint64_t x,
// Computes upper 64 bits of multiplication of a 32-bit unsigned integer and a // Computes upper 64 bits of multiplication of a 32-bit unsigned integer and a
// 64-bit unsigned integer. // 64-bit unsigned integer.
inline uint64_t umul96_upper64(uint32_t x, uint64_t y) noexcept { inline uint64_t umul96_upper64(uint32_t x, uint64_t y) noexcept {
return umul128_upper64(uint64_t(x) << 32, y); return umul128_upper64(static_cast<uint64_t>(x) << 32, y);
} }
// Computes lower 128 bits of multiplication of a 64-bit unsigned integer and a // Computes lower 128 bits of multiplication of a 64-bit unsigned integer and a
@ -1861,7 +1862,7 @@ FMT_INLINE int remove_trailing_zeros(uint64_t& n) noexcept {
FMT_ASSERT(n != 0, ""); FMT_ASSERT(n != 0, "");
// This magic number is ceil(2^90 / 10^8). // This magic number is ceil(2^90 / 10^8).
constexpr auto magic_number = uint64_t(12379400392853802749ull); constexpr uint64_t magic_number = 12379400392853802749ull;
auto nm = umul128(n, magic_number); auto nm = umul128(n, magic_number);
// Is n is divisible by 10^8? // Is n is divisible by 10^8?