fmtlib/fmt
1
0
Fork 1
mirror of https://github.com/fmtlib/fmt.git synced 2025-07-31 11:17:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix formatting of bool with FMT_COMPILE and add more tests

Browse Source
This commit is contained in:
Victor Zverovich
2020-06-14 07:16:50 -07:00
parent e956a14e9e
commit d702a68df2
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
include/fmt/format.h
View File

@ -3380,7 +3380,8 @@ inline std::string to_string(const T& value) {
} }
template <typename T, FMT_ENABLE_IF(std::is_integral<T>::value)> template <typename T, FMT_ENABLE_IF(std::is_integral<T>::value)>
inline std::string to_string(T value) { inline std::string to_string(T value) {
char buffer[detail::digits10<T>() + 2]; // Buffer should be large enough to store the number or "false" (for bool).
char buffer[(std::max)(detail::digits10<T>() + 2, 5)];
char* begin = buffer; char* begin = buffer;
char* end = detail::write<char>(begin, value); char* end = detail::write<char>(begin, value);
return std::string(begin, end); return std::string(begin, end);

9
test/compile-test.cc
View File

@ -144,8 +144,15 @@ TEST(CompileTest, EmptyFormatString) {
} }
#ifdef __cpp_if_constexpr #ifdef __cpp_if_constexpr
TEST(CompileTest, Basic) { TEST(CompileTest, FormatDefault) {
EXPECT_EQ("42", fmt::format(FMT_COMPILE("{}"), 42)); EXPECT_EQ("42", fmt::format(FMT_COMPILE("{}"), 42));
EXPECT_EQ("42", fmt::format(FMT_COMPILE("{}"), 42u));
EXPECT_EQ("42", fmt::format(FMT_COMPILE("{}"), 42ll));
EXPECT_EQ("42", fmt::format(FMT_COMPILE("{}"), 42ull));
EXPECT_EQ("true", fmt::format(FMT_COMPILE("{}"), true));
EXPECT_EQ("x", fmt::format(FMT_COMPILE("{}"), 'x'));
EXPECT_EQ("4.2", fmt::format(FMT_COMPILE("{}"), 4.2));
EXPECT_EQ("foo", fmt::format(FMT_COMPILE("{}"), "foo")); EXPECT_EQ("foo", fmt::format(FMT_COMPILE("{}"), "foo"));
EXPECT_EQ("foo", fmt::format(FMT_COMPILE("{}"), std::string("foo")));
} }
#endif #endif