fmtlib/fmt
1
0
Fork 1
mirror of https://github.com/fmtlib/fmt.git synced 2026-05-06 08:26:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Optimize format string parsing" because of a bug in MSVC

Browse Source 
https://godbolt.org/g/rpiDgh

This reverts commit f9e9bf0231.
This commit is contained in:
Victor Zverovich
2018-07-08 08:05:55 -07:00
parent 07b690a679
commit f21268aa72
3 changed files with 30 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/format-test.cc
+3 -5
View File
@@ -1760,18 +1760,16 @@ struct test_format_string_handler {
template <typename T>
FMT_CONSTEXPR void on_arg_id(T) {}
template <typename Iterator>
FMT_CONSTEXPR void on_replacement_field(Iterator) {}
FMT_CONSTEXPR void on_replacement_field(const char *) {}
template <typename Iterator>
FMT_CONSTEXPR Iterator on_format_specs(Iterator it) { return it; }
FMT_CONSTEXPR const char *on_format_specs(const char *s) { return s; }
FMT_CONSTEXPR void on_error(const char *) { error = true; }
bool error = false;
};
FMT_CONSTEXPR bool parse_string(fmt::string_view s) {
FMT_CONSTEXPR bool parse_string(const char *s) {
test_format_string_handler h;
fmt::internal::parse_format_string(s, h);
return !h.error;