diff --git a/include/fmt/core.h b/include/fmt/core.h index dd8dda8e..ece9ec45 100644 --- a/include/fmt/core.h +++ b/include/fmt/core.h @@ -911,8 +911,8 @@ struct buffer_context { typedef basic_format_context< std::back_insert_iterator>, Char> type; }; -typedef buffer_context::type context; -typedef buffer_context::type wcontext; +typedef buffer_context::type format_context; +typedef buffer_context::type wformat_context; namespace internal { template @@ -1008,8 +1008,9 @@ inline format_arg_store make_args(const Args & ... args) { } template -inline format_arg_store make_args(const Args & ... args) { - return format_arg_store(args...); +inline format_arg_store + make_args(const Args & ... args) { + return format_arg_store(args...); } /** Formatting arguments. */ @@ -1093,12 +1094,12 @@ class basic_format_args { /** An alias to ``basic_format_args``. */ // It is a separate type rather than a typedef to make symbols readable. -struct format_args: basic_format_args { +struct format_args: basic_format_args { template format_args(Args && ... arg) - : basic_format_args(std::forward(arg)...) {} + : basic_format_args(std::forward(arg)...) {} }; -typedef basic_format_args wformat_args; +typedef basic_format_args wformat_args; namespace internal { template @@ -1106,7 +1107,7 @@ struct named_arg_base { basic_string_view name; // Serialized value. - mutable char data[sizeof(basic_format_arg)]; + mutable char data[sizeof(basic_format_arg)]; named_arg_base(basic_string_view nm) : name(nm) {} @@ -1167,10 +1168,10 @@ inline void print_colored(color c, string_view format_str, vprint_colored(c, format_str, make_args(args...)); } -context::iterator vformat_to(internal::buffer &buf, string_view format_str, - format_args args); -wcontext::iterator vformat_to(internal::wbuffer &buf, wstring_view format_str, - wformat_args args); +format_context::iterator vformat_to( + internal::buffer &buf, string_view format_str, format_args args); +wformat_context::iterator vformat_to( + internal::wbuffer &buf, wstring_view format_str, wformat_args args); template struct is_contiguous : std::false_type {}; @@ -1211,12 +1212,12 @@ inline std::string format(string_view format_str, const Args & ... args) { // This should be just // return vformat(format_str, make_args(args...)); // but gcc has trouble optimizing the latter, so break it down. - format_arg_store as(args...); + format_arg_store as(args...); return vformat(format_str, as); } template inline std::wstring format(wstring_view format_str, const Args & ... args) { - format_arg_store as(args...); + format_arg_store as(args...); return vformat(format_str, as); } @@ -1233,7 +1234,7 @@ FMT_API void vprint(std::FILE *f, string_view format_str, format_args args); */ template inline void print(std::FILE *f, string_view format_str, const Args & ... args) { - format_arg_store as(args...); + format_arg_store as(args...); vprint(f, format_str, as); } @@ -1250,7 +1251,7 @@ FMT_API void vprint(string_view format_str, format_args args); */ template inline void print(string_view format_str, const Args & ... args) { - format_arg_store as(args...); + format_arg_store as(args...); vprint(format_str, as); } } // namespace fmt diff --git a/include/fmt/format.h b/include/fmt/format.h index ac0f4586..5b304aec 100644 --- a/include/fmt/format.h +++ b/include/fmt/format.h @@ -3368,28 +3368,28 @@ std::basic_string to_string(const basic_memory_buffer &buffer) { return std::basic_string(buffer.data(), buffer.size()); } -inline context::iterator vformat_to( +inline format_context::iterator vformat_to( internal::buffer &buf, string_view format_str, format_args args) { typedef back_insert_range range; return vformat_to>(buf, format_str, args); } -inline wcontext::iterator vformat_to( +inline wformat_context::iterator vformat_to( internal::wbuffer &buf, wstring_view format_str, wformat_args args) { typedef back_insert_range range; return vformat_to>(buf, format_str, args); } template -inline context::iterator format_to( +inline format_context::iterator format_to( memory_buffer &buf, string_view format_str, const Args & ... args) { return vformat_to(buf, format_str, make_args(args...)); } template -inline wcontext::iterator format_to( +inline wformat_context::iterator format_to( wmemory_buffer &buf, wstring_view format_str, const Args & ... args) { - return vformat_to(buf, format_str, make_args(args...)); + return vformat_to(buf, format_str, make_args(args...)); } template diff --git a/include/fmt/time.h b/include/fmt/time.h index 08199425..b5d81a72 100644 --- a/include/fmt/time.h +++ b/include/fmt/time.h @@ -110,7 +110,7 @@ struct formatter { return pointer_from(end); } - auto format(const std::tm &tm, context &ctx) -> decltype(ctx.begin()) { + auto format(const std::tm &tm, format_context &ctx) -> decltype(ctx.begin()) { internal::buffer &buf = internal::get_container(ctx.begin()); std::size_t start = buf.size(); for (;;) { diff --git a/src/format.cc b/src/format.cc index 738fd44b..41746612 100644 --- a/src/format.cc +++ b/src/format.cc @@ -17,8 +17,8 @@ template FMT_API char internal::thousands_sep(locale_provider *lp); template void basic_fixed_buffer::grow(std::size_t); -template void internal::arg_map::init( - const basic_format_args &args); +template void internal::arg_map::init( + const basic_format_args &args); template FMT_API int internal::char_traits::format_float( char *buffer, std::size_t size, const char *format, @@ -34,7 +34,7 @@ template FMT_API wchar_t internal::thousands_sep(locale_provider *lp); template void basic_fixed_buffer::grow(std::size_t); -template void internal::arg_map::init(const wformat_args &args); +template void internal::arg_map::init(const wformat_args &args); template FMT_API int internal::char_traits::format_float( wchar_t *buffer, std::size_t size, const wchar_t *format, diff --git a/test/custom-formatter-test.cc b/test/custom-formatter-test.cc index 1a0e9a37..610ef7c0 100644 --- a/test/custom-formatter-test.cc +++ b/test/custom-formatter-test.cc @@ -16,7 +16,7 @@ class custom_arg_formatter : typedef fmt::back_insert_range range; typedef fmt::arg_formatter base; - custom_arg_formatter(fmt::context &ctx, fmt::format_specs &s) + custom_arg_formatter(fmt::format_context &ctx, fmt::format_specs &s) : base(ctx, s) {} using base::operator(); diff --git a/test/format-impl-test.cc b/test/format-impl-test.cc index 079b2f27..79ddd396 100644 --- a/test/format-impl-test.cc +++ b/test/format-impl-test.cc @@ -38,8 +38,9 @@ struct ValueExtractor: fmt::internal::function { TEST(FormatTest, ArgConverter) { long long value = std::numeric_limits::max(); - auto arg = fmt::internal::make_arg(value); - visit(fmt::internal::arg_converter(arg, 'd'), arg); + auto arg = fmt::internal::make_arg(value); + visit(fmt::internal::arg_converter(arg, 'd'), + arg); EXPECT_EQ(value, visit(ValueExtractor(), arg)); } diff --git a/test/format-test.cc b/test/format-test.cc index a1a9e723..9bb40c8f 100644 --- a/test/format-test.cc +++ b/test/format-test.cc @@ -1101,7 +1101,7 @@ struct formatter { return it; } - auto format(const Date &d, context &ctx) -> decltype(ctx.begin()) { + auto format(const Date &d, format_context &ctx) -> decltype(ctx.begin()) { format_to(ctx.begin(), "{}-{}-{}", d.year(), d.month(), d.day()); return ctx.begin(); } @@ -1119,7 +1119,7 @@ class Answer {}; namespace fmt { template <> struct formatter : formatter { - auto format(Answer, fmt::context &ctx) -> decltype(ctx.begin()) { + auto format(Answer, fmt::format_context &ctx) -> decltype(ctx.begin()) { return formatter::format(42, ctx); } }; @@ -1409,7 +1409,7 @@ class mock_arg_formatter: typedef fmt::internal::arg_formatter_base base; typedef buffer_range range; - mock_arg_formatter(fmt::context &ctx, fmt::format_specs &s) + mock_arg_formatter(fmt::format_context &ctx, fmt::format_specs &s) : base(fmt::internal::get_container(ctx.begin()), s) { EXPECT_CALL(*this, call(42)); } @@ -1421,7 +1421,7 @@ class mock_arg_formatter: return base::operator()(value); } - iterator operator()(fmt::basic_format_arg::handle) { + iterator operator()(fmt::basic_format_arg::handle) { return base::operator()(fmt::monostate()); } }; @@ -1454,7 +1454,7 @@ struct variant { namespace fmt { template <> struct formatter : dynamic_formatter<> { - auto format(variant value, context& ctx) -> decltype(ctx.begin()) { + auto format(variant value, format_context& ctx) -> decltype(ctx.begin()) { if (value.type == variant::INT) return dynamic_formatter<>::format(42, ctx); return dynamic_formatter<>::format("foo", ctx); diff --git a/test/ostream-test.cc b/test/ostream-test.cc index 6ded223e..1570f5ff 100644 --- a/test/ostream-test.cc +++ b/test/ostream-test.cc @@ -41,17 +41,17 @@ TEST(OStreamTest, Enum) { typedef fmt::back_insert_range range; struct test_arg_formatter: fmt::arg_formatter { - test_arg_formatter(fmt::context &ctx, fmt::format_specs &s) + test_arg_formatter(fmt::format_context &ctx, fmt::format_specs &s) : fmt::arg_formatter(ctx, s) {} }; TEST(OStreamTest, CustomArg) { fmt::memory_buffer buffer; fmt::internal::buffer &base = buffer; - fmt::context ctx(std::back_inserter(base), "", fmt::format_args()); + fmt::format_context ctx(std::back_inserter(base), "", fmt::format_args()); fmt::format_specs spec; test_arg_formatter af(ctx, spec); - visit(af, fmt::internal::make_arg(TestEnum())); + visit(af, fmt::internal::make_arg(TestEnum())); EXPECT_EQ("TestEnum", std::string(buffer.data(), buffer.size())); } diff --git a/test/util-test.cc b/test/util-test.cc index 8f391822..54e6eebb 100644 --- a/test/util-test.cc +++ b/test/util-test.cc @@ -580,10 +580,10 @@ TEST(UtilTest, PointerArg) { } struct check_custom { - Result operator()(fmt::basic_format_arg::handle h) const { + Result operator()(fmt::basic_format_arg::handle h) const { fmt::memory_buffer buffer; fmt::internal::basic_buffer &base = buffer; - fmt::context ctx(std::back_inserter(base), "", fmt::format_args()); + fmt::format_context ctx(std::back_inserter(base), "", fmt::format_args()); h.format(ctx); EXPECT_EQ("test", std::string(buffer.data(), buffer.size())); return Result(); @@ -592,17 +592,18 @@ struct check_custom { TEST(UtilTest, CustomArg) { ::Test test; - typedef MockVisitor::handle> visitor; + typedef MockVisitor::handle> + visitor; testing::StrictMock v; EXPECT_CALL(v, visit(_)).WillOnce(testing::Invoke(check_custom())); - fmt::visit(v, make_arg(test)); + fmt::visit(v, make_arg(test)); } TEST(ArgVisitorTest, VisitInvalidArg) { typedef MockVisitor Visitor; testing::StrictMock visitor; EXPECT_CALL(visitor, visit(_)); - fmt::basic_format_arg arg; + fmt::basic_format_arg arg; visit(visitor, arg); }