home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-09-10 15:21:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix brightness command not sent when in white color mode (#150439)

Browse Source 
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
This commit is contained in:
wedsa5
2025-08-12 08:36:52 -06:00
committed by GitHub
parent 711afa306c
commit 07930b12d0
2 changed files with 55 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
homeassistant/components/tuya/light.py
View File

@@ -663,8 +663,11 @@ class TuyaLightEntity(TuyaEntity, LightEntity):
},
]
elif ATTR_BRIGHTNESS in kwargs and self._brightness:
elif self._brightness and (ATTR_BRIGHTNESS in kwargs or ATTR_WHITE in kwargs):
if ATTR_BRIGHTNESS in kwargs:
brightness = kwargs[ATTR_BRIGHTNESS]
else:
brightness = kwargs[ATTR_WHITE]
# If there is a min/max value, the brightness is actually limited.
# Meaning it is actually not on a 0-255 scale.

55
tests/components/tuya/test_light.py
View File

@@ -2,6 +2,7 @@
from __future__ import annotations
from typing import Any
from unittest.mock import patch
import pytest
@@ -42,11 +43,58 @@ async def test_platform_setup_and_discovery(
"mock_device_code",
["dj_mki13ie507rlry4r"],
)
@pytest.mark.parametrize(
("turn_on_input", "expected_commands"),
[
(
{
"white": True,
},
[
{"code": "switch_led", "value": True},
{"code": "work_mode", "value": "white"},
{"code": "bright_value_v2", "value": 546},
],
),
(
{
"brightness": 150,
},
[
{"code": "switch_led", "value": True},
{"code": "bright_value_v2", "value": 592},
],
),
(
{
"white": True,
"brightness": 150,
},
[
{"code": "switch_led", "value": True},
{"code": "work_mode", "value": "white"},
{"code": "bright_value_v2", "value": 592},
],
),
(
{
"white": 150,
},
[
{"code": "switch_led", "value": True},
{"code": "work_mode", "value": "white"},
{"code": "bright_value_v2", "value": 592},
],
),
],
)
async def test_turn_on_white(
hass: HomeAssistant,
mock_manager: ManagerCompat,
mock_config_entry: MockConfigEntry,
mock_device: CustomerDevice,
turn_on_input: dict[str, Any],
expected_commands: list[dict[str, Any]],
) -> None:
"""Test turn_on service."""
entity_id = "light.garage_light"
@@ -59,16 +107,13 @@ async def test_turn_on_white(
SERVICE_TURN_ON,
{
"entity_id": entity_id,
"white": 150,
**turn_on_input,
},
)
await hass.async_block_till_done()
mock_manager.send_commands.assert_called_once_with(
mock_device.id,
[
{"code": "switch_led", "value": True},
{"code": "work_mode", "value": "white"},
],
expected_commands,
)