home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-08-03 20:55:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

Disable pylint ignore_missing_annotations in config flow (#125322)

Browse Source 
* Disable pylint ignore_missing_annotations in config flow

* Add tests

* Ignore point
This commit is contained in:
epenet
2024-09-16 11:53:29 +02:00
committed by GitHub
parent 15bf6222f5
commit 18e2c2f6dd
3 changed files with 37 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
pylint/plugins/hass_enforce_type_hints.py
View File

@@ -28,6 +28,8 @@ _KNOWN_GENERIC_TYPES: set[str] = {
}
_KNOWN_GENERIC_TYPES_TUPLE = tuple(_KNOWN_GENERIC_TYPES)
_FORCE_ANNOTATION_PLATFORMS = ["config_flow"]
class _Special(Enum):
"""Sentinel values."""
@@ -3108,6 +3110,7 @@ class HassTypeHintChecker(BaseChecker):
_class_matchers: list[ClassTypeHintMatch]
_function_matchers: list[TypeHintMatch]
_module_node: nodes.Module
_module_platform: str | None
_in_test_module: bool
def visit_module(self, node: nodes.Module) -> None:
@@ -3115,24 +3118,22 @@ class HassTypeHintChecker(BaseChecker):
self._class_matchers = []
self._function_matchers = []
self._module_node = node
self._module_platform = _get_module_platform(node.name)
self._in_test_module = node.name.startswith("tests.")
if (
self._in_test_module
or (module_platform := _get_module_platform(node.name)) is None
):
if self._in_test_module or self._module_platform is None:
return
if module_platform in _PLATFORMS:
if self._module_platform in _PLATFORMS:
self._function_matchers.extend(_FUNCTION_MATCH["__any_platform__"])
if function_matches := _FUNCTION_MATCH.get(module_platform):
if function_matches := _FUNCTION_MATCH.get(self._module_platform):
self._function_matchers.extend(function_matches)
if class_matches := _CLASS_MATCH.get(module_platform):
if class_matches := _CLASS_MATCH.get(self._module_platform):
self._class_matchers.extend(class_matches)
if property_matches := _INHERITANCE_MATCH.get(module_platform):
if property_matches := _INHERITANCE_MATCH.get(self._module_platform):
self._class_matchers.extend(property_matches)
self._class_matchers.reverse()
@@ -3142,7 +3143,12 @@ class HassTypeHintChecker(BaseChecker):
) -> bool:
"""Check if we can skip the function validation."""
return (
self.linter.config.ignore_missing_annotations
# test modules are excluded from ignore_missing_annotations
not self._in_test_module
# some modules have checks forced
and self._module_platform not in _FORCE_ANNOTATION_PLATFORMS
# other modules are only checked ignore_missing_annotations
and self.linter.config.ignore_missing_annotations
and node.returns is None
and not _has_valid_annotations(annotations)
)