home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-07-31 11:18:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix mqtt callback exception logging (#118138)

Browse Source 
* Fix mqtt callback exception logging

* Improve code

* Add test
This commit is contained in:
Jan Bouwhuis
2024-05-25 22:46:33 +02:00
committed by GitHub
parent 569763b7a8
commit 521ed0a220
2 changed files with 43 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
homeassistant/components/mqtt/client.py
View File

@ -835,8 +835,13 @@ class MQTT:
msg: ReceiveMessage,
) -> str:
"""Return a string with the exception message."""
# if msg_callback is a partial we return the name of the first argument
if isinstance(msg_callback, partial):
call_back_name = getattr(msg_callback.args[0], "__name__") # type: ignore[unreachable]
else:
call_back_name = getattr(msg_callback, "__name__")
return (
f"Exception in {msg_callback.__name__} when handling msg on "
f"Exception in {call_back_name} when handling msg on "
f"'{msg.topic}': '{msg.payload}'" # type: ignore[str-bytes-safe]
)