home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-07-31 19:25:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Revert logic change

Browse Source
This commit is contained in:
epenet
2022-10-14 13:57:59 +00:00
parent 4769e84bae
commit 60959a0050
2 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/util/unit_system.py
View File

@@ -215,9 +215,7 @@ def get_unit_system(key: str) -> UnitSystem:
"""Get unit system based on key.""" """Get unit system based on key."""
if key == _CONF_UNIT_SYSTEM_IMPERIAL: if key == _CONF_UNIT_SYSTEM_IMPERIAL:
return IMPERIAL_SYSTEM return IMPERIAL_SYSTEM
if key == _CONF_UNIT_SYSTEM_METRIC: return METRIC_SYSTEM
return METRIC_SYSTEM
raise ValueError(f"`{key}` is not a valid unit system key")
validate_unit_system = vol.All( validate_unit_system = vol.All(

10
tests/util/test_unit_system.py
View File

@@ -342,15 +342,11 @@ def test_deprecated_name(
[ [
(_CONF_UNIT_SYSTEM_METRIC, METRIC_SYSTEM), (_CONF_UNIT_SYSTEM_METRIC, METRIC_SYSTEM),
(_CONF_UNIT_SYSTEM_IMPERIAL, IMPERIAL_SYSTEM), (_CONF_UNIT_SYSTEM_IMPERIAL, IMPERIAL_SYSTEM),
(None, METRIC_SYSTEM),
("", METRIC_SYSTEM),
("unknown_system", METRIC_SYSTEM),
], ],
) )
def test_get_unit_system(key: str, expected_system: UnitSystem) -> None: def test_get_unit_system(key: str, expected_system: UnitSystem) -> None:
"""Test get_unit_system.""" """Test get_unit_system."""
assert get_unit_system(key) is expected_system assert get_unit_system(key) is expected_system
@pytest.mark.parametrize("key", [None, "", "invalid_custom"])
def test_get_unit_system_invalid(key: str) -> None:
"""Test get_unit_system with an invalid key."""
with pytest.raises(ValueError, match=f"`{key}` is not a valid unit system key"):
_ = get_unit_system(key)