home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-07-29 18:28:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix last_reported_timestamp not being updated when last_reported is changed (#118341)

Browse Source 
* Reduce number of calls to last_reported_timestamp

When a state is created, last_update is always the same
as last_reported, and we only update it later if it changes
so we can pre-set the cached property to avoid it being
run when the recorder accesses it later.

* fix cache not being overridden

* coverage
This commit is contained in:
J. Nick Koston
2024-05-28 19:03:19 -10:00
committed by GitHub
parent f3fa843b9d
commit 76aa504e36
2 changed files with 26 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
homeassistant/core.py
View File

@ -1803,9 +1803,16 @@ class State:
# The recorder or the websocket_api will always call the timestamps,
# so we will set the timestamp values here to avoid the overhead of
# the function call in the property we know will always be called.
self.last_updated_timestamp = self.last_updated.timestamp()
if self.last_changed == self.last_updated:
self.__dict__["last_changed_timestamp"] = self.last_updated_timestamp
last_updated = self.last_updated
last_updated_timestamp = last_updated.timestamp()
self.last_updated_timestamp = last_updated_timestamp
if self.last_changed == last_updated:
self.__dict__["last_changed_timestamp"] = last_updated_timestamp
# If last_reported is the same as last_updated async_set will pass
# the same datetime object for both values so we can use an identity
# check here.
if self.last_reported is last_updated:
self.__dict__["last_reported_timestamp"] = last_updated_timestamp
@cached_property
def name(self) -> str:
@ -1822,8 +1829,6 @@ class State:
@cached_property
def last_reported_timestamp(self) -> float:
"""Timestamp of last report."""
if self.last_reported == self.last_updated:
return self.last_updated_timestamp
return self.last_reported.timestamp()
@cached_property
@ -2282,6 +2287,7 @@ class StateMachine:
# mypy does not understand this is only possible if old_state is not None
old_last_reported = old_state.last_reported # type: ignore[union-attr]
old_state.last_reported = now # type: ignore[union-attr]
old_state.last_reported_timestamp = timestamp # type: ignore[union-attr]
self._bus.async_fire_internal(
EVENT_STATE_REPORTED,
{