home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-07-29 18:28:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Mark database sessions that do not write data as read_only (#89600)

Browse Source 
* Mark sessions that do not write data as read_only

* Mark sessions that do not write data as read_only
This commit is contained in:
J. Nick Koston
2023-03-12 15:33:28 -10:00
committed by GitHub
parent 977a07de13
commit 85ca94e9d4
6 changed files with 22 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
homeassistant/components/recorder/util.py
View File

@ -110,8 +110,14 @@ def session_scope(
hass: HomeAssistant | None = None,
session: Session | None = None,
exception_filter: Callable[[Exception], bool] | None = None,
read_only: bool = False,
) -> Generator[Session, None, None]:
"""Provide a transactional scope around a series of operations."""
"""Provide a transactional scope around a series of operations.
read_only is used to indicate that the session is only used for reading
data and that no commit is required. It does not prevent the session
from writing and is not a security measure.
"""
if session is None and hass is not None:
session = get_instance(hass).get_session()
@ -121,7 +127,7 @@ def session_scope(
need_rollback = False
try:
yield session
if session.get_transaction():
if session.get_transaction() and not read_only:
need_rollback = True
session.commit()
except Exception as err: # pylint: disable=broad-except