home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-08-04 05:05:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add tests

Browse Source
This commit is contained in:
epenet
2022-10-14 12:36:27 +00:00
parent 57a80ec7e1
commit b0572233c4
2 changed files with 43 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
homeassistant/util/unit_system.py
View File

@@ -217,7 +217,7 @@ def get_unit_system(key: str) -> UnitSystem:
return IMPERIAL_SYSTEM return IMPERIAL_SYSTEM
if key == _CONF_UNIT_SYSTEM_METRIC: if key == _CONF_UNIT_SYSTEM_METRIC:
return METRIC_SYSTEM return METRIC_SYSTEM
raise ValueError("Invalid unit system key") raise ValueError(f"`{key}` is not a valid unit system key")
def get_default_key(use_metric: bool) -> str: def get_default_key(use_metric: bool) -> str:

47
tests/util/test_unit_system.py
View File

@@ -3,8 +3,6 @@ import pytest
from homeassistant.const import ( from homeassistant.const import (
ACCUMULATED_PRECIPITATION, ACCUMULATED_PRECIPITATION,
CONF_UNIT_SYSTEM_IMPERIAL,
CONF_UNIT_SYSTEM_METRIC,
LENGTH, LENGTH,
LENGTH_KILOMETERS, LENGTH_KILOMETERS,
LENGTH_METERS, LENGTH_METERS,
@@ -21,7 +19,15 @@ from homeassistant.const import (
WIND_SPEED, WIND_SPEED,
) )
from homeassistant.exceptions import HomeAssistantError from homeassistant.exceptions import HomeAssistantError
from homeassistant.util.unit_system import IMPERIAL_SYSTEM, METRIC_SYSTEM, UnitSystem from homeassistant.util.unit_system import (
_CONF_UNIT_SYSTEM_IMPERIAL,
_CONF_UNIT_SYSTEM_METRIC,
IMPERIAL_SYSTEM,
METRIC_SYSTEM,
UnitSystem,
get_default_key,
get_unit_system,
)
SYSTEM_NAME = "TEST" SYSTEM_NAME = "TEST"
INVALID_UNIT = "INVALID" INVALID_UNIT = "INVALID"
@@ -317,8 +323,8 @@ def test_is_metric(
@pytest.mark.parametrize( @pytest.mark.parametrize(
"unit_system, expected_name", "unit_system, expected_name",
[ [
(METRIC_SYSTEM, CONF_UNIT_SYSTEM_METRIC), (METRIC_SYSTEM, _CONF_UNIT_SYSTEM_METRIC),
(IMPERIAL_SYSTEM, CONF_UNIT_SYSTEM_IMPERIAL), (IMPERIAL_SYSTEM, _CONF_UNIT_SYSTEM_IMPERIAL),
], ],
) )
def test_deprecated_name( def test_deprecated_name(
@@ -330,3 +336,34 @@ def test_deprecated_name(
"Detected code that accesses the `name` property of the unit system." "Detected code that accesses the `name` property of the unit system."
in caplog.text in caplog.text
) )
@pytest.mark.parametrize(
"use_metric, expected_key",
[
(True, _CONF_UNIT_SYSTEM_METRIC),
(False, _CONF_UNIT_SYSTEM_IMPERIAL),
],
)
def test_get_default_key(use_metric: bool, expected_key: str) -> None:
"""Test get_default_key."""
assert get_default_key(use_metric) == expected_key
@pytest.mark.parametrize(
"key, expected_system",
[
(_CONF_UNIT_SYSTEM_METRIC, METRIC_SYSTEM),
(_CONF_UNIT_SYSTEM_IMPERIAL, IMPERIAL_SYSTEM),
],
)
def test_get_unit_system(key: str, expected_system: UnitSystem) -> None:
"""Test get_unit_system."""
assert get_unit_system(key) is expected_system
@pytest.mark.parametrize("key", [None, "", "invalid_custom"])
def test_get_unit_system_invalid(key: str) -> None:
"""Test get_unit_system with an invalid key."""
with pytest.raises(ValueError, match=f"`{key}` is not a valid unit system key"):
_ = get_unit_system(key)