home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-08-17 11:31:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use non-autospec mock for Reolink's light tests (#147621)

Browse Source
This commit is contained in:
Abílio Costa
2025-06-26 20:05:23 +01:00
committed by GitHub
parent 06d04c001d
commit b3131355b0
2 changed files with 26 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/components/reolink/conftest.py
View File

@@ -81,6 +81,8 @@ def _init_host_mock(host_mock: MagicMock) -> None:
host_mock.set_audio = AsyncMock() host_mock.set_audio = AsyncMock()
host_mock.set_email = AsyncMock() host_mock.set_email = AsyncMock()
host_mock.ONVIF_event_callback = AsyncMock() host_mock.ONVIF_event_callback = AsyncMock()
host_mock.set_whiteled = AsyncMock()
host_mock.set_state_light = AsyncMock()
host_mock.renew = AsyncMock() host_mock.renew = AsyncMock()
host_mock.is_nvr = True host_mock.is_nvr = True
host_mock.is_hub = False host_mock.is_hub = False

54
tests/components/reolink/test_light.py
View File

@@ -25,11 +25,11 @@ from tests.common import MockConfigEntry
async def test_light_state( async def test_light_state(
hass: HomeAssistant, hass: HomeAssistant,
config_entry: MockConfigEntry, config_entry: MockConfigEntry,
reolink_connect: MagicMock, reolink_host: MagicMock,
) -> None: ) -> None:
"""Test light entity state with floodlight.""" """Test light entity state with floodlight."""
reolink_connect.whiteled_state.return_value = True reolink_host.whiteled_state.return_value = True
reolink_connect.whiteled_brightness.return_value = 100 reolink_host.whiteled_brightness.return_value = 100
with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]): with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]):
assert await hass.config_entries.async_setup(config_entry.entry_id) assert await hass.config_entries.async_setup(config_entry.entry_id)
@@ -46,11 +46,11 @@ async def test_light_state(
async def test_light_brightness_none( async def test_light_brightness_none(
hass: HomeAssistant, hass: HomeAssistant,
config_entry: MockConfigEntry, config_entry: MockConfigEntry,
reolink_connect: MagicMock, reolink_host: MagicMock,
) -> None: ) -> None:
"""Test light entity with floodlight and brightness returning None.""" """Test light entity with floodlight and brightness returning None."""
reolink_connect.whiteled_state.return_value = True reolink_host.whiteled_state.return_value = True
reolink_connect.whiteled_brightness.return_value = None reolink_host.whiteled_brightness.return_value = None
with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]): with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]):
assert await hass.config_entries.async_setup(config_entry.entry_id) assert await hass.config_entries.async_setup(config_entry.entry_id)
@@ -67,7 +67,7 @@ async def test_light_brightness_none(
async def test_light_turn_off( async def test_light_turn_off(
hass: HomeAssistant, hass: HomeAssistant,
config_entry: MockConfigEntry, config_entry: MockConfigEntry,
reolink_connect: MagicMock, reolink_host: MagicMock,
) -> None: ) -> None:
"""Test light turn off service.""" """Test light turn off service."""
with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]): with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]):
@@ -83,9 +83,9 @@ async def test_light_turn_off(
{ATTR_ENTITY_ID: entity_id}, {ATTR_ENTITY_ID: entity_id},
blocking=True, blocking=True,
) )
reolink_connect.set_whiteled.assert_called_with(0, state=False) reolink_host.set_whiteled.assert_called_with(0, state=False)
reolink_connect.set_whiteled.side_effect = ReolinkError("Test error") reolink_host.set_whiteled.side_effect = ReolinkError("Test error")
with pytest.raises(HomeAssistantError): with pytest.raises(HomeAssistantError):
await hass.services.async_call( await hass.services.async_call(
LIGHT_DOMAIN, LIGHT_DOMAIN,
@@ -94,13 +94,11 @@ async def test_light_turn_off(
blocking=True, blocking=True,
) )
reolink_connect.set_whiteled.reset_mock(side_effect=True)
async def test_light_turn_on( async def test_light_turn_on(
hass: HomeAssistant, hass: HomeAssistant,
config_entry: MockConfigEntry, config_entry: MockConfigEntry,
reolink_connect: MagicMock, reolink_host: MagicMock,
) -> None: ) -> None:
"""Test light turn on service.""" """Test light turn on service."""
with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]): with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]):
@@ -116,11 +114,11 @@ async def test_light_turn_on(
{ATTR_ENTITY_ID: entity_id, ATTR_BRIGHTNESS: 51}, {ATTR_ENTITY_ID: entity_id, ATTR_BRIGHTNESS: 51},
blocking=True, blocking=True,
) )
reolink_connect.set_whiteled.assert_has_calls( reolink_host.set_whiteled.assert_has_calls(
[call(0, brightness=20), call(0, state=True)] [call(0, brightness=20), call(0, state=True)]
) )
reolink_connect.set_whiteled.side_effect = ReolinkError("Test error") reolink_host.set_whiteled.side_effect = ReolinkError("Test error")
with pytest.raises(HomeAssistantError): with pytest.raises(HomeAssistantError):
await hass.services.async_call( await hass.services.async_call(
LIGHT_DOMAIN, LIGHT_DOMAIN,
@@ -129,7 +127,7 @@ async def test_light_turn_on(
blocking=True, blocking=True,
) )
reolink_connect.set_whiteled.side_effect = ReolinkError("Test error") reolink_host.set_whiteled.side_effect = ReolinkError("Test error")
with pytest.raises(HomeAssistantError): with pytest.raises(HomeAssistantError):
await hass.services.async_call( await hass.services.async_call(
LIGHT_DOMAIN, LIGHT_DOMAIN,
@@ -138,7 +136,7 @@ async def test_light_turn_on(
blocking=True, blocking=True,
) )
reolink_connect.set_whiteled.side_effect = InvalidParameterError("Test error") reolink_host.set_whiteled.side_effect = InvalidParameterError("Test error")
with pytest.raises(HomeAssistantError): with pytest.raises(HomeAssistantError):
await hass.services.async_call( await hass.services.async_call(
LIGHT_DOMAIN, LIGHT_DOMAIN,
@@ -147,16 +145,14 @@ async def test_light_turn_on(
blocking=True, blocking=True,
) )
reolink_connect.set_whiteled.reset_mock(side_effect=True)
async def test_host_light_state( async def test_host_light_state(
hass: HomeAssistant, hass: HomeAssistant,
config_entry: MockConfigEntry, config_entry: MockConfigEntry,
reolink_connect: MagicMock, reolink_host: MagicMock,
) -> None: ) -> None:
"""Test host light entity state with status led.""" """Test host light entity state with status led."""
reolink_connect.state_light = True reolink_host.state_light = True
with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]): with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]):
assert await hass.config_entries.async_setup(config_entry.entry_id) assert await hass.config_entries.async_setup(config_entry.entry_id)
@@ -172,7 +168,7 @@ async def test_host_light_state(
async def test_host_light_turn_off( async def test_host_light_turn_off(
hass: HomeAssistant, hass: HomeAssistant,
config_entry: MockConfigEntry, config_entry: MockConfigEntry,
reolink_connect: MagicMock, reolink_host: MagicMock,
) -> None: ) -> None:
"""Test host light turn off service.""" """Test host light turn off service."""
@@ -181,7 +177,7 @@ async def test_host_light_turn_off(
return False return False
return True return True
reolink_connect.supported = mock_supported reolink_host.supported = mock_supported
with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]): with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]):
assert await hass.config_entries.async_setup(config_entry.entry_id) assert await hass.config_entries.async_setup(config_entry.entry_id)
@@ -196,9 +192,9 @@ async def test_host_light_turn_off(
{ATTR_ENTITY_ID: entity_id}, {ATTR_ENTITY_ID: entity_id},
blocking=True, blocking=True,
) )
reolink_connect.set_state_light.assert_called_with(False) reolink_host.set_state_light.assert_called_with(False)
reolink_connect.set_state_light.side_effect = ReolinkError("Test error") reolink_host.set_state_light.side_effect = ReolinkError("Test error")
with pytest.raises(HomeAssistantError): with pytest.raises(HomeAssistantError):
await hass.services.async_call( await hass.services.async_call(
LIGHT_DOMAIN, LIGHT_DOMAIN,
@@ -207,13 +203,11 @@ async def test_host_light_turn_off(
blocking=True, blocking=True,
) )
reolink_connect.set_state_light.reset_mock(side_effect=True)
async def test_host_light_turn_on( async def test_host_light_turn_on(
hass: HomeAssistant, hass: HomeAssistant,
config_entry: MockConfigEntry, config_entry: MockConfigEntry,
reolink_connect: MagicMock, reolink_host: MagicMock,
) -> None: ) -> None:
"""Test host light turn on service.""" """Test host light turn on service."""
@@ -222,7 +216,7 @@ async def test_host_light_turn_on(
return False return False
return True return True
reolink_connect.supported = mock_supported reolink_host.supported = mock_supported
with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]): with patch("homeassistant.components.reolink.PLATFORMS", [Platform.LIGHT]):
assert await hass.config_entries.async_setup(config_entry.entry_id) assert await hass.config_entries.async_setup(config_entry.entry_id)
@@ -237,9 +231,9 @@ async def test_host_light_turn_on(
{ATTR_ENTITY_ID: entity_id}, {ATTR_ENTITY_ID: entity_id},
blocking=True, blocking=True,
) )
reolink_connect.set_state_light.assert_called_with(True) reolink_host.set_state_light.assert_called_with(True)
reolink_connect.set_state_light.side_effect = ReolinkError("Test error") reolink_host.set_state_light.side_effect = ReolinkError("Test error")
with pytest.raises(HomeAssistantError): with pytest.raises(HomeAssistantError):
await hass.services.async_call( await hass.services.async_call(
LIGHT_DOMAIN, LIGHT_DOMAIN,