home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-07-29 18:28:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix mqtt not publishing null payload payload to remove discovery (#118261)

Browse Source
This commit is contained in:
Jan Bouwhuis
2024-05-28 00:53:22 +02:00
committed by GitHub
parent 6067ea2454
commit bfc3194661
8 changed files with 47 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
tests/components/mqtt/test_init.py
View File

@ -223,49 +223,50 @@ async def test_publish(
) -> None:
"""Test the publish function."""
mqtt_mock = await mqtt_mock_entry()
publish_mock: MagicMock = mqtt_mock._mqttc.publish
await mqtt.async_publish(hass, "test-topic", "test-payload")
await hass.async_block_till_done()
assert mqtt_mock.async_publish.called
assert mqtt_mock.async_publish.call_args[0] == (
assert publish_mock.called
assert publish_mock.call_args[0] == (
"test-topic",
"test-payload",
0,
False,
)
mqtt_mock.reset_mock()
publish_mock.reset_mock()
await mqtt.async_publish(hass, "test-topic", "test-payload", 2, True)
await hass.async_block_till_done()
assert mqtt_mock.async_publish.called
assert mqtt_mock.async_publish.call_args[0] == (
assert publish_mock.called
assert publish_mock.call_args[0] == (
"test-topic",
"test-payload",
2,
True,
)
mqtt_mock.reset_mock()
publish_mock.reset_mock()
mqtt.publish(hass, "test-topic2", "test-payload2")
await hass.async_block_till_done()
assert mqtt_mock.async_publish.called
assert mqtt_mock.async_publish.call_args[0] == (
assert publish_mock.called
assert publish_mock.call_args[0] == (
"test-topic2",
"test-payload2",
0,
False,
)
mqtt_mock.reset_mock()
publish_mock.reset_mock()
mqtt.publish(hass, "test-topic2", "test-payload2", 2, True)
await hass.async_block_till_done()
assert mqtt_mock.async_publish.called
assert mqtt_mock.async_publish.call_args[0] == (
assert publish_mock.called
assert publish_mock.call_args[0] == (
"test-topic2",
"test-payload2",
2,
True,
)
mqtt_mock.reset_mock()
publish_mock.reset_mock()
# test binary pass-through
mqtt.publish(
@ -276,8 +277,8 @@ async def test_publish(
False,
)
await hass.async_block_till_done()
assert mqtt_mock.async_publish.called
assert mqtt_mock.async_publish.call_args[0] == (
assert publish_mock.called
assert publish_mock.call_args[0] == (
"test-topic3",
b"\xde\xad\xbe\xef",
0,
@ -285,6 +286,25 @@ async def test_publish(
)
mqtt_mock.reset_mock()
# test null payload
mqtt.publish(
hass,
"test-topic3",
None,
0,
False,
)
await hass.async_block_till_done()
assert publish_mock.called
assert publish_mock.call_args[0] == (
"test-topic3",
None,
0,
False,
)
publish_mock.reset_mock()
async def test_convert_outgoing_payload(hass: HomeAssistant) -> None:
"""Test the converting of outgoing MQTT payloads without template."""