home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-07-31 19:25:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Ensure domain is correct format (#58429)

Browse Source
This commit is contained in:
Paulus Schoutsen
2021-10-25 15:56:07 -07:00
committed by GitHub
parent a813608185
commit cd3e51b3e7
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
homeassistant/loader.py
View File

@@ -576,6 +576,9 @@ async def async_get_integration(hass: HomeAssistant, domain: str) -> Integration
async def _async_get_integration(hass: HomeAssistant, domain: str) -> Integration: async def _async_get_integration(hass: HomeAssistant, domain: str) -> Integration:
if "." in domain:
raise ValueError(f"Invalid domain {domain}")
# Instead of using resolve_from_root we use the cache of custom # Instead of using resolve_from_root we use the cache of custom
# components to find the integration. # components to find the integration.
if integration := (await async_get_custom_components(hass)).get(domain): if integration := (await async_get_custom_components(hass)).get(domain):

6
tests/test_loader.py
View File

@@ -540,3 +540,9 @@ async def test_custom_integration_missing(hass, caplog):
with pytest.raises(loader.IntegrationNotFound): with pytest.raises(loader.IntegrationNotFound):
await loader.async_get_integration(hass, "test1") await loader.async_get_integration(hass, "test1")
async def test_validation(hass):
"""Test we raise if invalid domain passed in."""
with pytest.raises(ValueError):
await loader.async_get_integration(hass, "some.thing")