From dda6ccccd22c6019f62228637f0d075f8bc65e14 Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Thu, 13 Jun 2024 08:32:55 +0200 Subject: [PATCH] Fix dangerous-default-value in nest tests (#119561) * Fix dangerous-default-value in nest tests * Adjust * Adjust --- tests/components/nest/test_device_trigger.py | 6 +++++- tests/components/nest/test_events.py | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/components/nest/test_device_trigger.py b/tests/components/nest/test_device_trigger.py index 759fb56d213..1820096d2a6 100644 --- a/tests/components/nest/test_device_trigger.py +++ b/tests/components/nest/test_device_trigger.py @@ -1,5 +1,7 @@ """The tests for Nest device triggers.""" +from typing import Any + from google_nest_sdm.event import EventMessage import pytest from pytest_unordered import unordered @@ -30,7 +32,9 @@ def platforms() -> list[str]: return ["camera"] -def make_camera(device_id, name=DEVICE_NAME, traits={}): +def make_camera( + device_id, name: str = DEVICE_NAME, *, traits: dict[str, Any] +) -> dict[str, Any]: """Create a nest camera.""" traits = traits.copy() traits.update( diff --git a/tests/components/nest/test_events.py b/tests/components/nest/test_events.py index f817378aea1..08cf9f775b7 100644 --- a/tests/components/nest/test_events.py +++ b/tests/components/nest/test_events.py @@ -53,7 +53,7 @@ def device_traits() -> list[str]: @pytest.fixture(autouse=True) def device( - device_type: str, device_traits: dict[str, Any], create_device: CreateDevice + device_type: str, device_traits: list[str], create_device: CreateDevice ) -> None: """Fixture to create a device under test.""" return create_device.create( @@ -70,7 +70,7 @@ def event_view(d: Mapping[str, Any]) -> Mapping[str, Any]: return {key: value for key, value in d.items() if key in EVENT_KEYS} -def create_device_traits(event_traits=[]): +def create_device_traits(event_traits: list[str]) -> dict[str, Any]: """Create fake traits for a device.""" result = { "sdm.devices.traits.Info": {