46 Commits

Author SHA1 Message Date
Erik Montnemery
f83c8de8d3 Update signature of platforms' async_setup_entry (#138201) 2025-02-10 21:08:03 +01:00
Michael
ac3eead8ac Explicitly pass in the config_entry in ping coordinator (#138041)
explicitly pass in the config_entry in coordinator
2025-02-09 14:44:37 +01:00
Jan-Philipp Benecke
f6cf23a8c2 Remove deprecated attributes from ping binary sensor (#125760) 2024-09-11 16:17:20 +02:00
G Johansson
f14e8b728c Remove YAML import from ping (#120176) 2024-06-22 20:39:32 +02:00
Jan-Philipp Benecke
2c99925286 Use runtime_data in ping (#118332) 2024-05-29 08:12:54 +02:00
Marc Mueller
988c71ecc5 Add empty line after module docstring [n-q] (#112702) 2024-03-08 15:04:07 +01:00
Jan-Philipp Benecke
911cf60678 Address late review for Ping (#112123)
* Address late review for Ping

* Fix import
2024-03-03 18:10:22 +01:00
Jan-Philipp Benecke
25551fa938 Move Ping binary sensor attributes to sensor entities (#112004)
* Move Ping binary sensor attributes to sensor entities

* Process code review

* Update snapshot
2024-03-03 11:08:28 +01:00
Jan-Philipp Benecke
a9a95ad881 Revert "Introduce base entity for ping" (#104682) 2023-11-29 08:42:02 +01:00
Jan-Philipp Benecke
6f54aaf564 Introduce base entity for ping (#104197) 2023-11-24 11:20:34 +01:00
Jan-Philipp Benecke
dfff22b5ce Add update coordinator to ping (#104148)
* Add update coordinator to ping

* Remove config_entry from coordinator

* Remove PARALLEL_UPDATES and set to hass.data
2023-11-18 17:07:58 +01:00
Jan-Philipp Benecke
e5bc25523e Add config flow for Ping (#103743) 2023-11-17 13:30:30 -06:00
Jan-Philipp Benecke
62d8472757 Move ping classes to their own module (#102448) 2023-10-21 22:12:59 -10:00
Jan-Philipp Benecke
3c455391c2 Use dataclass to carry data in ping (#99803)
Co-authored-by: J. Nick Koston <nick@koston.org>
2023-10-20 11:46:33 -10:00
Marc Mueller
063ce9159d Use asyncio.timeout [o-s] (#98451) 2023-08-15 17:21:49 +02:00
G Johansson
67586caaf9 Cleanup ping (#95168) 2023-06-25 09:00:52 -05:00
epenet
753c790a25 Use async_timeout in integrations (#88697) 2023-02-24 08:13:03 -05:00
J. Nick Koston
03eea7bd3f Avoid subprocess memory copy when c library supports posix_spawn (#87958)
* use posix spawn on alpine

* Avoid subprocess memory copy when c library supports posix_spawn

By default python 3.10 will use the fork() which has to
copy all the memory of the parent process (in our case
this can be huge since Home Assistant core can use
hundreds of megabytes of RAM). By using posix_spawn
this is avoided.

In python 3.11 vfork will also be available
https://github.com/python/cpython/issues/80004#issuecomment-1093810689
https://github.com/python/cpython/pull/11671 but we won't
always be able to use it and posix_spawn is considered safer
https://bugzilla.kernel.org/show_bug.cgi?id=215813#c14

The subprocess library doesn't know about musl though
even though it supports posix_spawn https://git.musl-libc.org/cgit/musl/log/src/process/posix_spawn.c
so we have to teach it since it only has checks for glibc
1b736838e6/Lib/subprocess.py (L745)

The constant is documented as being able to be flipped here:
https://docs.python.org/3/library/subprocess.html#disabling-use-of-vfork-or-posix-spawn

* Avoid subprocess memory copy when c library supports posix_spawn

By default python 3.10 will use the fork() which has to
copy memory of the parent process (in our case
this can be huge since Home Assistant core can use
hundreds of megabytes of RAM). By using posix_spawn
this is avoided and subprocess creation does not
get discernibly slow the larger the Home Assistant
python process grows.

In python 3.11 vfork will also be available
https://github.com/python/cpython/issues/80004#issuecomment-1093810689
https://github.com/python/cpython/pull/11671 but we won't
always be able to use it and posix_spawn is considered safer
https://bugzilla.kernel.org/show_bug.cgi?id=215813#c14

The subprocess library doesn't know about musl though
even though it supports posix_spawn https://git.musl-libc.org/cgit/musl/log/src/process/posix_spawn.c
so we have to teach it since it only has checks for glibc
1b736838e6/Lib/subprocess.py (L745)

The constant is documented as being able to be flipped here:
https://docs.python.org/3/library/subprocess.html#disabling-use-of-vfork-or-posix-spawn

* missed some

* adjust more tests

* coverage
2023-02-13 09:02:51 -05:00
epenet
275438adf3 Improve typing in ping binary sensor (#87073) 2023-02-02 16:31:09 -05:00
epenet
474844744b Improve entity type hints [p] (#77871) 2022-09-06 09:51:33 +02:00
Joakim Sørensen
b086c8d898 Set ping data to None instead of False (#65013) 2022-01-27 10:03:45 +01:00
epenet
211b99e22d Remove ping from mypy ignored modules (#64439)
Co-authored-by: epenet <epenet@users.noreply.github.com>
2022-01-19 20:59:20 +01:00
Erik Montnemery
0fa4f616ed Remove Windows workarounds from ping (#64069) 2022-01-13 20:43:00 +01:00
epenet
d94f68d697 Add setup type hints [n-r] (#63607)
Co-authored-by: epenet <epenet@users.noreply.github.com>
2022-01-07 16:28:24 +01:00
Robert Hillis
a5cf783e6a Use enums in ping (#62066) 2021-12-16 15:38:02 +01:00
Guess
2a99ef2046 Set PARALLEL_UPDATES for ping binary sensor (#59524)
Changing PARALLEL_UPDATES from 0 (unlimited) to 50 as with many sensors (above 500) successful pings weren't being recorded. Resolves https://github.com/home-assistant/core/issues/54860
2021-11-11 08:38:01 +01:00
Daniel Hjelseth Høyer
fbad453c89 Pylint 2.9.3 (#52972)
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
2021-07-14 21:44:57 -07:00
J. Nick Koston
68714c2067 Update ping to use asyncio function in icmplib (#50808) 2021-06-02 06:10:33 -10:00
J. Nick Koston
bee55a0494 Prevent ping integration from delaying startup (#43869) 2021-03-31 15:06:49 +02:00
Franck Nijhof
6932cf9534 Use contextlib.suppress where possible (#48189) 2021-03-23 14:36:43 +01:00
Marc Mueller
3d2b81a401 Update typing 11 (#48072) 2021-03-18 13:21:46 +01:00
Erik Montnemery
14ff6d4d1f Update integrations p-s to override extra_state_attributes() (#47759) 2021-03-11 21:23:20 +01:00
J. Nick Koston
c7bbba9d48 Reduce icmplib ping timeout to match ping binary behavior (#41620) 2020-10-11 11:12:27 -05:00
J. Nick Koston
f3d50e2104 Do not log an error when a host is unreachable while pinging (#40024) 2020-09-13 16:44:37 +02:00
springstan
3d4ef8cfe1 Use connectivity device class constant in various integrations (#39972) 2020-09-12 13:21:57 -05:00
J. Nick Koston
b5005430be Fix ping log level to be debug instead of warning (#39900) 2020-09-10 12:10:43 -04:00
J. Nick Koston
b7ad83c655 Use a unique id for each icmplib ping to avoid mixing unrelated responses (#39830) 2020-09-09 22:19:14 +02:00
J. Nick Koston
57848cdf35 Add the ability to reload ping platforms from yaml (#39344) 2020-08-28 12:40:30 -05:00
J. Nick Koston
7c191388a9 Use icmplib for ping when available (#39284)
* Use icmplib for ping when available

* Update homeassistant/components/ping/binary_sensor.py

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>

* Revert "Update homeassistant/components/ping/binary_sensor.py"

This reverts commit 618f42512a.

* move it up so its easier to see

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
2020-08-28 08:50:09 -05:00
Tomasz
81b4c6956b Make ping binary_sensor update async (#35301)
* async_update

* isort and pylint

* @shenxn suggestions

Co-authored-by: Xiaonan Shen <s@sxn.dev>

* async_update

* store the command from the beginning

* command as string

* f-string instead of str.format

* create_subprocess_shell > create_subprocess_exec
more logs

* isort

* types

* use asyncio.wait_for

* Update homeassistant/components/ping/binary_sensor.py

Co-authored-by: J. Nick Koston <nick@koston.org>

* @bdraco review changes

* Update homeassistant/components/ping/binary_sensor.py

Co-authored-by: J. Nick Koston <nick@koston.org>

Co-authored-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: J. Nick Koston <nick@koston.org>
2020-08-18 17:25:50 -05:00
J. Nick Koston
a91f5b7192 Prevent ping integration from blocking startup (#38504) 2020-08-05 12:43:35 +02:00
Erik Montnemery
b022e08db9 Rename BinarySensorDevice to BinarySensorEntity (#34462)
* Rename BinarySensorDevice to BinarySensorEntity

* Tweak

* Move deprecation warning to __new__, add test

* Move deprecation warning back to __init__

* Move deprecation warning to __init_subclass
2020-04-23 21:57:07 +02:00
Bas Nijholt
21816eeed4 Sort imports according to PEP8 for components starting with "P" (#29775) 2019-12-09 14:29:39 +01:00
Paulus Schoutsen
4de97abc3a Black 2019-07-31 12:25:30 -07:00
Tobias Sauerwein
048b100eea Clean up docstrings (#22679)
* Clean up docstrings

* Fix long lines

* Fix more docstrings

* Fix more docstrings

* Fix more docstrings
2019-04-03 17:40:03 +02:00
Paulus Schoutsen
f5076188ef Consolidate all platforms that have no tests (#22096)
* Consolidate

* Fix tests

* Update imports

* Fix import

* Use importlib because integration and package share name

* Fix more tests

* Update .coveragerc and CODEOWNERS
2019-03-16 20:44:05 -07:00