me-no-dev/ESPAsyncWebServer
1
0
Fork 1
mirror of https://github.com/me-no-dev/ESPAsyncWebServer.git synced 2026-01-26 08:42:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

AsyncEvents/ServerSideEvents: prevent internal DOS by prevent overflowing messageQueue (#621)

Browse Source 
* Prevent tcp/wifi DOS lockup by preventing number of messages in queue, drop otherwise

* Define (renamed) MAX_SSE_Clients
This commit is contained in:
Arjan Filius
2019-10-17 09:05:13 +02:00
committed by Me No Dev
parent a84f16989a
commit f13685ee97
2 changed files with 25 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/AsyncEventSource.cpp
View File

@@ -184,10 +184,14 @@ void AsyncEventSourceClient::_queueMessage(AsyncEventSourceMessage *dataMessage)
delete dataMessage;
return;
}
_messageQueue.add(dataMessage);
_runQueue();
if(_messageQueue.length() >= SSE_MAX_QUEUED_MESSAGES){
ets_printf("ERROR: Too many messages queued\n");
delete dataMessage;
} else {
_messageQueue.add(dataMessage);
}
if(_client->canSend())
_runQueue();
}
void AsyncEventSourceClient::_onAck(size_t len, uint32_t time){