microsoft/GSL
1
0
Fork 1
mirror of https://github.com/microsoft/GSL.git synced 2026-05-04 11:44:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix return type of templated span.subspan() (#625)

Browse Source 
* Added support for returning fixed-spize spans from subspan().

* Addressed issues from code review.

* Took simpler approach to static data member.

* Subtle fix to support MSVC 15.

* Helps to not introduce extraneous >
This commit is contained in:
Neil MacIntosh
2018-03-03 19:12:45 -08:00
committed by GitHub
parent cbd64c9ff6
commit 6a33b97a84
2 changed files with 38 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/span_tests.cpp
+12
View File
@@ -776,6 +776,7 @@ TEST_CASE("subspan")
{
span<int, 5> av = arr;
CHECK((av.subspan<2, 2>().size() == 2));
CHECK(decltype(av.subspan<2, 2>())::extent == 2);
CHECK(av.subspan(2, 2).size() == 2);
CHECK(av.subspan(2, 3).size() == 3);
}
@@ -783,13 +784,16 @@ TEST_CASE("subspan")
{
span<int, 5> av = arr;
CHECK((av.subspan<0, 0>().size() == 0));
CHECK(decltype(av.subspan<0,0>())::extent == 0);
CHECK(av.subspan(0, 0).size() == 0);
}
{
span<int, 5> av = arr;
CHECK((av.subspan<0, 5>().size() == 5));
CHECK(decltype(av.subspan<0, 5>())::extent == 5);
CHECK(av.subspan(0, 5).size() == 5);
CHECK_THROWS_AS(av.subspan(0, 6).size(), fail_fast);
CHECK_THROWS_AS(av.subspan(1, 5).size(), fail_fast);
}
@@ -797,14 +801,22 @@ TEST_CASE("subspan")
{
span<int, 5> av = arr;
CHECK((av.subspan<4, 0>().size() == 0));
CHECK(decltype(av.subspan<4, 0>())::extent == 0);
CHECK(av.subspan(4, 0).size() == 0);
CHECK(av.subspan(5, 0).size() == 0);
CHECK_THROWS_AS(av.subspan(6, 0).size(), fail_fast);
}
{
span<int, 5> av = arr;
CHECK((av.subspan<1>().size() == 4));
CHECK(decltype(av.subspan<1>())::extent == 4);
}
{
span<int> av;
CHECK((av.subspan<0, 0>().size() == 0));
CHECK((decltype(av.subspan<0, 0>())::extent == 0));
CHECK(av.subspan(0, 0).size() == 0);
CHECK_THROWS_AS((av.subspan<1, 0>().size()), fail_fast);
}