addressing comments

This commit is contained in:
Jordan Maples [MSFT]
2019-12-19 14:05:02 -08:00
parent 3539bd8008
commit 8577033f13
13 changed files with 87 additions and 71 deletions

View File

@@ -25,12 +25,14 @@
//disable warnings from gtest
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wundef"
#endif
#endif // __clang__ || __GNUC__
#if __clang__
#pragma GCC diagnostic ignored "-Wglobal-constructors"
#pragma GCC diagnostic ignored "-Wused-but-marked-unused"
#pragma GCC diagnostic ignored "-Wcovered-switch-default"
#endif
#endif // __clang__
#include <gtest/gtest.h>
@@ -44,8 +46,9 @@
using namespace gsl;
namespace{
static const char *deathstring("Expected Death");
namespace
{
static constexpr char deathstring[] = "Expected Death";
void f(int& i) { i += 1; }
static int j = 0;
void g() { j += 1; }
@@ -153,4 +156,4 @@ TEST(utils_tests, narrow)
#if __clang__ || __GNUC__
#pragma GCC diagnostic pop
#endif
#endif // __clang__ || __GNUC__