Suppress unsafe-buffer-usage

.github/workflows/android.yml

@@ -1,9 +1,4 @@
 name: CI_Android
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
-  cancel-in-progress: true
-
 on:
   push:
     branches: [ main ]
@@ -12,30 +7,26 @@ on:
 
 jobs:
   Android:
-    runs-on: macos-latest-large
+    runs-on: macos-latest
     defaults:
       run:
         working-directory: build
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v2
 
       - name: Create build directory
         run: mkdir -p build
         working-directory: .
 
-      - uses: actions/setup-java@v4
-        with:
-          java-version: 8
-          distribution: zulu
-
-      - name: Start Emulator
+      - name: Start emulator
         run: |
           echo "y" | $ANDROID_HOME/tools/bin/sdkmanager --install 'system-images;android-24;default;x86_64'
           echo "no" | $ANDROID_HOME/tools/bin/avdmanager create avd -n xamarin_android_emulator -k 'system-images;android-24;default;x86_64' --force
           $ANDROID_HOME/emulator/emulator -list-avds
-          echo "Starting emulator..."
-          nohup $ANDROID_HOME/emulator/emulator -no-audio -no-snapshot -avd xamarin_android_emulator &> /dev/null &
-          echo "Emulator starting in background"
+          echo "Starting emulator"
+          # Start emulator in background
+          nohup $ANDROID_HOME/emulator/emulator -avd xamarin_android_emulator -no-snapshot > /dev/null 2>&1 &
+          echo "Emulator starting"
 
       - name: Configure
         run: cmake -Werror=dev -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_LATEST_HOME/build/cmake/android.toolchain.cmake -DANDROID_PLATFORM=16 -DANDROID_ABI=x86_64 -DCMAKE_BUILD_TYPE=Debug ..
@@ -44,11 +35,11 @@ jobs:
         run: cmake --build . --parallel
 
       - name: Wait for emulator ready
-        timeout-minutes: 2
         run: |
           $ANDROID_HOME/platform-tools/adb wait-for-device shell 'while [[ -z $(getprop sys.boot_completed | tr -d '\r') ]]; do sleep 10; done; input keyevent 82'
           $ANDROID_HOME/platform-tools/adb devices
           $ANDROID_HOME/platform-tools/adb shell getprop ro.product.cpu.abi
+          echo "Emulator started"
 
       - name: Deploy tests
         run: |

.github/workflows/cmake/action.yml

@@ -1,56 +0,0 @@
-name: Composite CMake
-inputs:
-  cmake_generator:
-    required: false
-    type: string
-    default: 'Unix Makefiles'
-  cmake_build_type:
-    required: true
-    type: string
-    default: ''
-  cmake_cxx_compiler:
-    required: false 
-    type: string 
-  gsl_cxx_standard:
-    required: true
-    type: number
-  extra_cmake_args:
-    required: false
-    type: string
-    default: ''
-  build_cmd:
-    required: true 
-    type: string 
-    default: 'make'
-  test_cmd:
-    required: false
-    type: string 
-    default: 'make test'
-  shell:
-    required: false 
-    type: string
-    default: 'bash'
-
-
-runs:
-  using: composite
-  steps:
-    - name: Create build directory
-      run: mkdir build
-      shell: ${{ inputs.shell }}
-
-    - name: Configure CMake
-      working-directory: build
-      run: cmake -G "${{ inputs.cmake_generator }}" -DCMAKE_BUILD_TYPE=${{ inputs.cmake_build_type }} -DCMAKE_CXX_COMPILER=${{ inputs.cmake_cxx_compiler }} -DGSL_CXX_STANDARD=${{ inputs.gsl_cxx_standard }} -DCI_TESTING:BOOL=ON -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -Werror=dev ${{ inputs.extra_cmake_args }} ..
-      shell: ${{ inputs.shell }}
-
-    - name: Build
-      working-directory: build
-      run: ${{ inputs.build_cmd }}
-      shell: ${{ inputs.shell }}
-
-    - name: Test
-      working-directory: build
-      run: ${{ inputs.test_cmd }}
-      shell: ${{ inputs.shell }} 
-

.github/workflows/cmake_find_package.yml

@@ -13,7 +13,7 @@ jobs:
       matrix:
         os: [ ubuntu-latest, macos-latest ]
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
       - uses: lukka/get-cmake@latest
         with:
           cmakeVersion: 3.14.0

.github/workflows/compilers.yml

@@ -1,104 +0,0 @@
-name: Compiler Integration Tests
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
-  cancel-in-progress: true
-
-on:
-  push:
-    branches: [ main ]
-  pull_request:
-    branches: [ main ]
-
-# These jobs are correlated with the officially supported compilers
-# and toolsets. If you change any versions, please update README.md.
-
-jobs:
-  gcc:
-    strategy:
-      matrix:
-        gcc_version: [ 10, 11, 12 ]
-        build_type: [ Debug, Release ]
-        cxx_version: [ 14, 17, 20, 23 ]
-        exclude:
-          - gcc_version: 10
-            cxx_version: 23
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Run CMake (configure, build, test)
-        uses: ./.github/workflows/cmake
-        with:
-          cmake_build_type: ${{ matrix.build_type }}
-          cmake_cxx_compiler: g++-${{ matrix.gcc_version }}
-          gsl_cxx_standard: ${{ matrix.cxx_version }}
-          
-  clang:
-    strategy:
-      matrix:
-        clang_version: [ 13, 14, 15 ]
-        build_type: [ Debug, Release ]
-        cxx_version: [ 14, 17, 20, 23 ]
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-     
-      - name: Run CMake (configure, build, test)
-        uses: ./.github/workflows/cmake
-        with:
-          cmake_build_type: ${{ matrix.build_type }}
-          cmake_cxx_compiler: clang++-${{ matrix.clang_version }}
-          gsl_cxx_standard: ${{ matrix.cxx_version }}
-
-  xcode:
-    strategy:
-      matrix:
-        xcode_version: [ '14.3.1', '15.4' ]
-        build_type: [ Debug, Release ]
-        cxx_version: [ 14, 17, 20, 23 ]
-    runs-on: macos-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: select xcode version
-        run: sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode_version }}.app
-
-      - name: Run CMake (configure, build, test)
-        uses: ./.github/workflows/cmake
-        with:
-          cmake_build_type: ${{ matrix.build_type }}
-          cmake_cxx_compiler: clang++
-          gsl_cxx_standard: ${{ matrix.cxx_version }}
-
-  VisualStudio:
-    strategy:
-      matrix:
-        generator: [ 'Visual Studio 16 2019', 'Visual Studio 17 2022' ]
-        image: [ windows-2019, windows-2022 ]
-        build_type: [ Debug, Release ]
-        extra_args: [ '', '-T ClangCL' ]
-        cxx_version: [ 14, 17, 20, 23 ]
-        exclude:
-          - generator: 'Visual Studio 17 2022'
-            image: windows-2019
-          - generator: 'Visual Studio 16 2019'
-            image: windows-2022
-          - generator: 'Visual Studio 16 2019'
-            cxx_version: 23
-    runs-on: ${{ matrix.image }}
-    steps:
-      - uses: actions/checkout@v4
-      - uses: microsoft/setup-msbuild@v2
-
-      - name: Run CMake (configure, build, test)
-        uses: ./.github/workflows/cmake
-        with:
-          cmake_generator: ${{ matrix.generator }}
-          cmake_build_type: ${{ matrix.build_type }}
-          gsl_cxx_standard: ${{ matrix.cxx_version }}
-          extra_cmake_args: ${{ matrix.extra_args }}
-          build_cmd: msbuild GSL.sln
-          test_cmd: ctest . --output-on-failure --no-compress-output
-          shell: pwsh
-

.github/workflows/ios.yml

@@ -12,7 +12,7 @@ jobs:
       run:
         working-directory: build
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v2
 
       - name: Create build directory
         run: mkdir -p build

CMakeLists.txt

@@ -1,6 +1,6 @@
 cmake_minimum_required(VERSION 3.14...3.16)
 
-project(GSL VERSION 4.1.0 LANGUAGES CXX)
+project(GSL VERSION 4.0.0 LANGUAGES CXX)
 
 add_library(GSL INTERFACE)
 add_library(Microsoft.GSL::GSL ALIAS GSL)

README.md

@@ -86,17 +86,24 @@ This is based on [CppCoreGuidelines semi-specification](https://github.com/isocp
 
 # Quick Start
 ## Supported Compilers / Toolsets
-The GSL officially supports recent major versions of Visual Studio with both MSVC and LLVM, GCC, Clang, and XCode with Apple-Clang.
-For each of these major versions, the GSL officially supports C++14, C++17, C++20, and C++23 (when supported by the compiler).
-Below is a table showing the versions currently being tested (also see [.github/workflows/compilers.yml](the workflow).)
+The GSL officially supports the latest and previous major versions of VS with MSVC & LLVM, GCC, Clang, and XCode with Apple-Clang.
+Within these two major versions, we try to target the latest minor updates / revisions (although this may be affected by
+delays between a toolchain's release and when it becomes widely available for use).
+Below is a table showing the versions currently being tested.
 
 Compiler |Toolset Versions Currently Tested
 :------- |--:
- GCC | 10, 11, 12
- XCode | 14.3.1, 15.4
- Clang | 13, 14, 15
- Visual Studio with MSVC | VS2019, VS2022 
- Visual Studio with LLVM | VS2019, VS2022
+ XCode | 13.2.1 & 12.5.1
+ GCC | 11[^1] & 10[^2]
+ Clang | 12[^2] & 11[^2]
+ Visual Studio with MSVC | VS2022[^3] & VS2019[^4]
+ Visual Studio with LLVM | VS2022[^3] & VS2019[^4]
+
+
+[^1]: Precise version may be found in the [latest CI results](https://dev.azure.com/cppstat/GSL/_build?definitionId=1&branchFilter=26).
+[^2]: Precise version may be found in the [latest CI results](https://dev.azure.com/cppstat/GSL/_build?definitionId=1&branchFilter=26). Should be the version specified [here](https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md#language-and-runtime).
+[^3]: Precise version may be found in the [latest CI results](https://dev.azure.com/cppstat/GSL/_build?definitionId=1&branchFilter=26). Should be the version specified [here](https://github.com/actions/virtual-environments/blob/main/images/win/Windows2022-Readme.md#visual-studio-enterprise-2022).
+[^4]: Precise version may be found in the [latest CI results](https://dev.azure.com/cppstat/GSL/_build?definitionId=1&branchFilter=26). Should be the version specified [here](https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#visual-studio-enterprise-2019).
 
 ---
 If you successfully port GSL to another platform, we would love to hear from you!
@@ -185,7 +192,7 @@ target_link_libraries(foobar PRIVATE Microsoft.GSL::GSL)
 
 ### FetchContent
 
-If you are using CMake version 3.11+ you can use the official [FetchContent module](https://cmake.org/cmake/help/latest/module/FetchContent.html).
+If you are using CMake version 3.11+ you can use the offical [FetchContent module](https://cmake.org/cmake/help/latest/module/FetchContent.html).
 This allows you to easily incorporate GSL into your project.
 
 ```cmake
@@ -197,7 +204,7 @@ include(FetchContent)
 
 FetchContent_Declare(GSL
     GIT_REPOSITORY "https://github.com/microsoft/GSL"
-    GIT_TAG "v4.1.0"
+    GIT_TAG "v4.0.0"
     GIT_SHALLOW ON
 )
 
@@ -209,7 +216,3 @@ target_link_libraries(foobar PRIVATE Microsoft.GSL::GSL)
 ## Debugging visualization support
 
 For Visual Studio users, the file [GSL.natvis](./GSL.natvis) in the root directory of the repository can be added to your project if you would like more helpful visualization of GSL types in the Visual Studio debugger than would be offered by default.
-
-## See Also
-
-For information on [Microsoft Gray Systems Lab (GSL)](https://aka.ms/gsl) of applied data management and system research see <https://aka.ms/gsl>.

azure-pipelines.yml

@@ -0,0 +1,66 @@
+trigger:
+  - main
+
+pr:
+  autoCancel: true
+
+stages:
+- stage: GCC
+  dependsOn: []
+  jobs:
+  - template: ./pipelines/jobs.yml
+    parameters:
+      compiler: gcc
+      image: ubuntu-20.04
+      compilerVersions: [ 11, 10 ]
+      setupfile: 'setup_gcc.yml'
+
+- stage: Clang
+  dependsOn: []
+  jobs:
+  - template: ./pipelines/jobs.yml
+    parameters:
+      compiler: clang
+      image: ubuntu-20.04
+      compilerVersions: [ 12, 11 ]
+      setupfile: 'setup_clang.yml'
+
+- stage: Xcode
+  dependsOn: []
+  jobs:
+  - template: ./pipelines/jobs.yml
+    parameters:
+      compiler: 'Xcode'
+      image: macOS-11
+      compilerVersions: [ '12.5.1', '13.2.1' ]
+      setupfile: 'setup_apple.yml'
+
+- stage: VS_MSVC
+  dependsOn: []
+  jobs:
+  - template: ./pipelines/jobs.yml
+    parameters:
+      compiler: 'VS2019 (MSVC)'
+      compilerVersions: [ 'default' ]
+      image: windows-2019
+  - template: ./pipelines/jobs.yml
+    parameters:
+      compiler: 'VS2022 (MSVC)'
+      compilerVersions: [ 'default' ]
+      image: windows-2022
+
+- stage: VS_LLVM
+  dependsOn: []
+  jobs:
+  - template: ./pipelines/jobs.yml
+    parameters:
+      compiler: 'VS2019 (LLVM)'
+      compilerVersions: [ 'default' ]
+      image: windows-2019
+      extraCmakeArgs: '-T ClangCL'
+  - template: ./pipelines/jobs.yml
+    parameters:
+      compiler: 'VS2022 (LLVM)'
+      compilerVersions: [ 'default' ]
+      image: windows-2022
+      extraCmakeArgs: '-T ClangCL'

docs/headers.md

@@ -133,13 +133,6 @@ constexpr byte operator~(byte b) noexcept;
 
 Bitwise negation of a `byte`. Flips all bits. Zeroes become ones, ones become zeroes.
 
-```cpp
-template <class IntegerType, class = std::enable_if_t<std::is_integral<IntegerType>::value>>
-constexpr IntegerType to_integer(byte b) noexcept;
-```
-
-Convert the given `byte` value to an integral type.
-
 ```cpp
 template <typename T>
 constexpr byte to_byte(T t) noexcept;
@@ -811,7 +804,7 @@ void operator=(const final_action&) = delete;
 void operator=(final_action&&)      = delete;
 ```
 
-Move construction is allowed. Copy construction is deleted. Copy and move assignment are also explicitly deleted.
+Move construction is allowed. Copy construction is deleted. Copy and move assignment are also explicitely deleted.
 
 #### <a name="H-util-finally" />Non-member functions
 ```cpp

include/gsl/byte

@@ -19,6 +19,8 @@
 
 #include <type_traits>
 
+// VS2017 15.8 added support for the __cpp_lib_byte definition
+// To do: drop _HAS_STD_BYTE when support for pre 15.8 expires
 #ifdef _MSC_VER
 
 #pragma warning(push)
@@ -29,15 +31,18 @@
 
 #ifndef GSL_USE_STD_BYTE
 // this tests if we are under MSVC and the standard lib has std::byte and it is enabled
-#if defined(__cpp_lib_byte) && __cpp_lib_byte >= 201603
+#if (defined(_HAS_STD_BYTE) && _HAS_STD_BYTE) ||                                                   \
+    (defined(__cpp_lib_byte) && __cpp_lib_byte >= 201603)
 
 #define GSL_USE_STD_BYTE 1
 
-#else // defined(__cpp_lib_byte) && __cpp_lib_byte >= 201603
+#else // (defined(_HAS_STD_BYTE) && _HAS_STD_BYTE) || (defined(__cpp_lib_byte) && __cpp_lib_byte >=
+      // 201603)
 
 #define GSL_USE_STD_BYTE 0
 
-#endif // defined(__cpp_lib_byte) && __cpp_lib_byte >= 201603
+#endif // (defined(_HAS_STD_BYTE) && _HAS_STD_BYTE) || (defined(__cpp_lib_byte) && __cpp_lib_byte >=
+       // 201603)
 #endif // GSL_USE_STD_BYTE
 
 #else // _MSC_VER
@@ -162,7 +167,7 @@ constexpr byte to_byte(T t) noexcept
 {
     static_assert(std::is_same<T, unsigned char>::value,
                   "gsl::to_byte(t) must be provided an unsigned char, otherwise data loss may occur. "
-                  "If you are calling to_byte with an integer constant use: gsl::to_byte<t>() version.");
+                  "If you are calling to_byte with an integer contant use: gsl::to_byte<t>() version.");
     return byte(t);
 }
 

include/gsl/gsl

@@ -17,7 +17,6 @@
 #ifndef GSL_GSL_H
 #define GSL_GSL_H
 
-// IWYU pragma: begin_exports
 #include "algorithm"   // copy
 #include "assert"      // Ensures/Expects
 #include "byte"        // byte
@@ -29,6 +28,5 @@
 #ifdef __cpp_exceptions
 #include "narrow" // narrow()
 #endif
-// IWYU pragma: end_exports
 
 #endif // GSL_GSL_H

include/gsl/narrow

@@ -30,12 +30,13 @@ struct narrowing_error : public std::exception
 template <class T, class U, typename std::enable_if<std::is_arithmetic<T>::value>::type* = nullptr>
 // clang-format off
 GSL_SUPPRESS(type.1) // NO-FORMAT: attribute
+GSL_SUPPRESS(f.6) // NO-FORMAT: attribute // TODO: MSVC /analyze does not recognise noexcept(false)
 GSL_SUPPRESS(es.46) // NO-FORMAT: attribute // The warning suggests that a floating->unsigned conversion can occur
                                             // in the static_cast below, and that gsl::narrow should be used instead.
                                             // Suppress this warning, since gsl::narrow is defined in terms of
                                             // static_cast
     // clang-format on
-    constexpr T narrow(U u)
+    constexpr T narrow(U u) noexcept(false)
 {
     constexpr const bool is_different_signedness =
         (std::is_signed<T>::value != std::is_signed<U>::value);
@@ -66,8 +67,9 @@ GSL_SUPPRESS(p.2) // NO-FORMAT: attribute // don't rely on undefined behavior
 template <class T, class U, typename std::enable_if<!std::is_arithmetic<T>::value>::type* = nullptr>
 // clang-format off
 GSL_SUPPRESS(type.1) // NO-FORMAT: attribute
+GSL_SUPPRESS(f.6) // NO-FORMAT: attribute // TODO: MSVC /analyze does not recognise noexcept(false)
     // clang-format on
-    constexpr T narrow(U u)
+    constexpr T narrow(U u) noexcept(false)
 {
     const T t = narrow_cast<T>(u);
 

include/gsl/pointers

@@ -19,11 +19,12 @@
 
 #include "assert" // for Ensures, Expects
 
+#include <algorithm>    // for forward
 #include <cstddef>      // for ptrdiff_t, nullptr_t, size_t
-#include <functional>   // for less, greater
-#include <memory>       // for shared_ptr, unique_ptr, hash
+#include <memory>       // for shared_ptr, unique_ptr
+#include <system_error> // for hash
 #include <type_traits>  // for enable_if_t, is_convertible, is_assignable
-#include <utility>      // for declval, forward
+#include <utility>      // for declval
 
 #if !defined(GSL_NO_IOSTREAMS)
 #include <iosfwd> // for ostream

include/gsl/span

@@ -42,7 +42,7 @@
 #pragma warning(disable : 4702) // unreachable code
 
 // Turn MSVC /analyze rules that generate too much noise. TODO: fix in the tool.
-#pragma warning(disable : 26495) // uninitialized member when constructor calls constructor
+#pragma warning(disable : 26495) // uninitalized member when constructor calls constructor
 #pragma warning(disable : 26446) // parser bug does not allow attributes on some templates
 
 #endif // _MSC_VER
@@ -53,7 +53,7 @@
 #define GSL_USE_STATIC_CONSTEXPR_WORKAROUND
 #endif // !(defined(__cplusplus) && (__cplusplus >= 201703L))
 
-// GCC 7 does not like the signed unsigned mismatch (size_t ptrdiff_t)
+// GCC 7 does not like the signed unsigned missmatch (size_t ptrdiff_t)
 // While there is a conversion from signed to unsigned, it happens at
 // compiletime, so the compiler wouldn't have to warn indiscriminately, but
 // could check if the source value actually doesn't fit into the target type
@@ -64,12 +64,10 @@
 #endif
 
 // Turn off clang unsafe buffer warnings as all accessed are guarded by runtime checks
-#if defined(__clang__)
-#if __has_warning("-Wunsafe-buffer-usage")
+#if defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wunsafe-buffer-usage"
-#endif // __has_warning("-Wunsafe-buffer-usage")
-#endif // defined(__clang__)
+#endif // defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
 
 namespace gsl
 {
@@ -854,10 +852,8 @@ as_writable_bytes(span<ElementType, Extent> s) noexcept
 #pragma GCC diagnostic pop
 #endif // __GNUC__ > 6
 
-#if defined(__clang__)
-#if __has_warning("-Wunsafe-buffer-usage")
+#if defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
 #pragma clang diagnostic pop
-#endif // __has_warning("-Wunsafe-buffer-usage")
-#endif // defined(__clang__)
+#endif
 
 #endif // GSL_SPAN_H

include/gsl/util

@@ -41,12 +41,10 @@
 #endif // _MSC_VER
 
 // Turn off clang unsafe buffer warnings as all accessed are guarded by runtime checks
-#if defined(__clang__)
-#if __has_warning("-Wunsafe-buffer-usage")
+#if defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wunsafe-buffer-usage"
-#endif // __has_warning("-Wunsafe-buffer-usage")
-#endif // defined(__clang__)
+#endif // defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
 
 #if defined(__cplusplus) && (__cplusplus >= 201703L)
 #define GSL_NODISCARD [[nodiscard]]
@@ -162,10 +160,8 @@ constexpr auto at(std::span<T, extent> sp, const index i) -> decltype(sp[sp.size
 
 #endif // _MSC_VER
 
-#if defined(__clang__)
-#if __has_warning("-Wunsafe-buffer-usage")
+#if defined(__clang__) && __has_warning("-Wunsafe-buffer-usage")
 #pragma clang diagnostic pop
-#endif // __has_warning("-Wunsafe-buffer-usage")
-#endif // defined(__clang__)
+#endif
 
 #endif // GSL_UTIL_H

pipelines/jobs.yml

@@ -0,0 +1,43 @@
+parameters:
+  CXXVersions: [ 14, 17, 20 ]
+  buildTypes: [ 'Debug', 'Release' ]
+  image: ''
+
+  compiler: ''
+  compilerVersions: ["default"] # if default value, simply uses whatever version is on the machine.
+                                # the text of this default value doesn't actually matter.
+  setupfile: ''
+  extraCmakeArgs: ''
+
+jobs:
+- ${{ each compilerVersion in parameters.compilerVersions }}:
+  - ${{ each CXXVersion in parameters.CXXVersions }}:
+    - ${{ each buildType in parameters.buildTypes }}:
+      - job:
+        displayName: ${{ format('{0} {1} C++{2} {3}', parameters.compiler, compilerVersion, CXXVersion, buildType) }}
+        pool:
+            vmImage: ${{ parameters.image }}
+        continueOnError: false
+
+        steps:
+          - ${{ if not(eq(parameters.setupfile, '')) }}:
+            - template: ${{ parameters.setupfile }}
+              parameters:
+                version: ${{ compilerVersion }}
+
+          - task: CMake@1
+            name: Configure
+            inputs:
+              workingDirectory: build
+              cmakeArgs: '-DGSL_CXX_STANDARD=${{ CXXVersion }} -DCMAKE_BUILD_TYPE=${{ buildType }} -DCI_TESTING:BOOL=ON -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -Werror=dev ${{ parameters.extraCmakeArgs }} .. '
+
+          - task: CMake@1
+            name: Build
+            inputs:
+              workingDirectory: build
+              cmakeArgs: '--build . '
+
+          - script: ctest . --output-on-failure --no-compress-output
+            name: CTest
+            workingDirectory: build
+            failOnStderr: true

pipelines/setup_apple.yml

@@ -0,0 +1,9 @@
+parameters:
+    version: 0
+
+steps:
+  - script: |
+      if [ "${{ parameters.version }}" != "default" ]; then sudo xcode-select -switch /Applications/Xcode_${{ parameters.version }}.app; fi
+
+    displayName: "Setup Xcode Version"
+    failOnStderr: true

pipelines/setup_clang.yml

@@ -0,0 +1,13 @@
+parameters:
+    version: 0
+
+steps:
+  - script: |
+      echo "##vso[task.setvariable variable=CXX;]${CXX}"
+      echo "##vso[task.setvariable variable=CC;]${CC}"
+
+    displayName: "Setup Clang Version"
+    failOnStderr: true
+    env:
+      CC: clang-${{ parameters.version }}
+      CXX: clang++-${{ parameters.version }}

pipelines/setup_gcc.yml

@@ -0,0 +1,14 @@
+parameters:
+    version: 0
+
+steps:
+  - script: |
+      echo "##vso[task.setvariable variable=CXX;]${CXX}"
+      echo "##vso[task.setvariable variable=CC;]${CC}"
+      if [ "${{ parameters.version }}" = "11" ]; then sudo apt-get install $CXX; fi
+
+    displayName: "Setup GCC Version"
+    failOnStderr: true
+    env:
+      CC: gcc-${{ parameters.version }}
+      CXX: g++-${{ parameters.version }}

tests/CMakeLists.txt

@@ -146,7 +146,6 @@ else()
           -Wno-global-constructors # GTest
           -Wno-missing-prototypes
           -Wno-padded
-          -Wno-switch-default
           -Wno-unknown-attributes
           -Wno-used-but-marked-unused # GTest EXPECT_DEATH
           -Wno-weak-vtables

tests/span_compatibility_tests.cpp

@@ -519,7 +519,7 @@ TEST(span_compatibility_tests, assertion_tests)
 
 // assertions for span's definition
 static_assert(std::is_same<decltype(gsl::dynamic_extent), const std::size_t>::value,
-              "gsl::dynamic_extent must be represented as std::size_t");
+              "gsl::dynamic_extent must be respresented as std::size_t");
 static_assert(gsl::dynamic_extent == static_cast<std::size_t>(-1),
               "gsl::dynamic_extent must be defined as the max value of std::size_t");