mirror of
https://github.com/microsoft/GSL.git
synced 2026-07-04 23:50:54 +02:00
b2f6bec48e
* clang-format improvements - Add a clang-format linter check to the PR pipeline - Apply clang-format to files where the linter initially failed - Remove `CommentPragmas` from `.clang-format` - Remove all `// clang-format off` and `// NO-FORMAT` as they are not needed - Remove a commented out `GSL_SUPPRESS` * clang-format 20 * pipeline fail * Update .github/workflows/clang-format.yml Co-authored-by: Carson Radtke <nosrac925@gmail.com> * output used clang-format version * installed version is 18 which replaces "GSL_SUPPRESS(bounds.1)" with "GSL_SUPPRESS(bounds .1)" * only include/gsl, not include to prevent formatting of include/CMakeLists.txt * apply clang-format[-20] In a VS2026 developer command prompt I ran `clang-format -i include\gsl\* --assume-filename x.cpp`. This was necessary because VS GUI does not format files without an extension :(. Please note that `--assume-filename` is necessary here, otherwise the files will not be formatted. Surprisingly the behaviour for the formatter differs from the behaviour of `lang-format(-20) --dry-run --Werror include/gsl/*` where clang-format recognizes that the files is C++. * change "#if 0" back to original version with comments only * formatting scripts for windows and linux for linux with linter (shfmt and shellcheck) * add WhitespaceSensitiveMacros: [GSL_SUPPRESS] * provide path for clang-format (Windows) Currently not clear to me: On my personal computer at home, when I start "Developer Command Prompt for VS18", I can run `clang-format` without providing the path. On my managed (domain) company computer, when I start "Developer Command Prompt for VS18", I can NOT run `clang-format` without providing the path. I need to call `"%VCINSTALLDIR%Tools\Llvm\bin\clang-format"`. I have no idea what the difference is. At least the version `"%VCINSTALLDIR%Tools\Llvm\bin\clang-format"` works on both computers, so I add the path. --------- Co-authored-by: Werner Henze <w.henze@avm.de> Co-authored-by: Carson Radtke <nosrac925@gmail.com> Co-authored-by: Werner Henze <werner.henze+gitcommits@posteo.de>
174 lines
5.5 KiB
C++
174 lines
5.5 KiB
C++
///////////////////////////////////////////////////////////////////////////////
|
|
//
|
|
// Copyright (c) 2015 Microsoft Corporation. All rights reserved.
|
|
//
|
|
// This code is licensed under the MIT License (MIT).
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
// THE SOFTWARE.
|
|
//
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <gsl/util> // for at
|
|
|
|
#include <array> // for array
|
|
#include <cstddef> // for size_t
|
|
#include <exception> // for terminate
|
|
#include <initializer_list> // for initializer_list
|
|
#include <vector> // for vector
|
|
#if defined(__cplusplus) && __cplusplus >= 202002L
|
|
#include <span>
|
|
#endif // __cplusplus >= 202002L
|
|
|
|
#include "deathTestCommon.h"
|
|
|
|
TEST(at_tests, static_array)
|
|
{
|
|
int a[4] = {1, 2, 3, 4};
|
|
const int (&c_a)[4] = a;
|
|
|
|
for (int i = 0; i < 4; ++i)
|
|
{
|
|
EXPECT_TRUE(&gsl::at(a, i) == &a[i]);
|
|
EXPECT_TRUE(&gsl::at(c_a, i) == &a[i]);
|
|
}
|
|
|
|
const auto terminateHandler = std::set_terminate([] {
|
|
std::cerr << "Expected Death. static_array";
|
|
std::abort();
|
|
});
|
|
const auto expected = GetExpectedDeathString(terminateHandler);
|
|
|
|
EXPECT_DEATH(gsl::at(a, -1), expected);
|
|
EXPECT_DEATH(gsl::at(a, 4), expected);
|
|
EXPECT_DEATH(gsl::at(c_a, -1), expected);
|
|
EXPECT_DEATH(gsl::at(c_a, 4), expected);
|
|
}
|
|
|
|
TEST(at_tests, std_array)
|
|
{
|
|
std::array<int, 4> a = {1, 2, 3, 4};
|
|
const std::array<int, 4>& c_a = a;
|
|
|
|
for (int i = 0; i < 4; ++i)
|
|
{
|
|
EXPECT_TRUE(&gsl::at(a, i) == &a[static_cast<std::size_t>(i)]);
|
|
EXPECT_TRUE(&gsl::at(c_a, i) == &a[static_cast<std::size_t>(i)]);
|
|
}
|
|
|
|
const auto terminateHandler = std::set_terminate([] {
|
|
std::cerr << "Expected Death. std_array";
|
|
std::abort();
|
|
});
|
|
const auto expected = GetExpectedDeathString(terminateHandler);
|
|
|
|
EXPECT_DEATH(gsl::at(a, -1), expected);
|
|
EXPECT_DEATH(gsl::at(a, 4), expected);
|
|
EXPECT_DEATH(gsl::at(c_a, -1), expected);
|
|
EXPECT_DEATH(gsl::at(c_a, 4), expected);
|
|
}
|
|
|
|
TEST(at_tests, std_vector)
|
|
{
|
|
std::vector<int> a = {1, 2, 3, 4};
|
|
const std::vector<int>& c_a = a;
|
|
|
|
for (int i = 0; i < 4; ++i)
|
|
{
|
|
EXPECT_TRUE(&gsl::at(a, i) == &a[static_cast<std::size_t>(i)]);
|
|
EXPECT_TRUE(&gsl::at(c_a, i) == &a[static_cast<std::size_t>(i)]);
|
|
}
|
|
|
|
const auto terminateHandler = std::set_terminate([] {
|
|
std::cerr << "Expected Death. std_vector";
|
|
std::abort();
|
|
});
|
|
const auto expected = GetExpectedDeathString(terminateHandler);
|
|
|
|
EXPECT_DEATH(gsl::at(a, -1), expected);
|
|
EXPECT_DEATH(gsl::at(a, 4), expected);
|
|
EXPECT_DEATH(gsl::at(c_a, -1), expected);
|
|
EXPECT_DEATH(gsl::at(c_a, 4), expected);
|
|
}
|
|
|
|
TEST(at_tests, InitializerList)
|
|
{
|
|
const std::initializer_list<int> a = {1, 2, 3, 4};
|
|
|
|
for (int i = 0; i < 4; ++i)
|
|
{
|
|
EXPECT_TRUE(gsl::at(a, i) == i + 1);
|
|
EXPECT_TRUE(gsl::at({1, 2, 3, 4}, i) == i + 1);
|
|
}
|
|
|
|
const auto terminateHandler = std::set_terminate([] {
|
|
std::cerr << "Expected Death. InitializerList";
|
|
std::abort();
|
|
});
|
|
const auto expected = GetExpectedDeathString(terminateHandler);
|
|
|
|
EXPECT_DEATH(gsl::at(a, -1), expected);
|
|
EXPECT_DEATH(gsl::at(a, 4), expected);
|
|
EXPECT_DEATH(gsl::at({1, 2, 3, 4}, -1), expected);
|
|
EXPECT_DEATH(gsl::at({1, 2, 3, 4}, 4), expected);
|
|
}
|
|
|
|
#if defined(FORCE_STD_SPAN_TESTS) || defined(__cpp_lib_span) && __cpp_lib_span >= 202002L
|
|
TEST(at_tests, std_span)
|
|
{
|
|
std::vector<int> vec{1, 2, 3, 4, 5};
|
|
std::span sp{vec};
|
|
|
|
std::vector<int> cvec{1, 2, 3, 4, 5};
|
|
std::span csp{cvec};
|
|
|
|
for (gsl::index i = 0; i < gsl::narrow_cast<gsl::index>(vec.size()); ++i)
|
|
{
|
|
EXPECT_TRUE(&gsl::at(sp, i) == &vec[gsl::narrow_cast<size_t>(i)]);
|
|
EXPECT_TRUE(&gsl::at(csp, i) == &cvec[gsl::narrow_cast<size_t>(i)]);
|
|
}
|
|
|
|
const auto terminateHandler = std::set_terminate([] {
|
|
std::cerr << "Expected Death. std_span";
|
|
std::abort();
|
|
});
|
|
const auto expected = GetExpectedDeathString(terminateHandler);
|
|
|
|
EXPECT_DEATH(gsl::at(sp, -1), expected);
|
|
EXPECT_DEATH(gsl::at(sp, gsl::narrow_cast<gsl::index>(sp.size())), expected);
|
|
EXPECT_DEATH(gsl::at(csp, -1), expected);
|
|
EXPECT_DEATH(gsl::at(csp, gsl::narrow_cast<gsl::index>(sp.size())), expected);
|
|
}
|
|
#endif // defined(FORCE_STD_SPAN_TESTS) || defined(__cpp_lib_span) && __cpp_lib_span >= 202002L
|
|
|
|
#if !defined(_MSC_VER) || defined(__clang__) || _MSC_VER >= 1910
|
|
static constexpr bool test_constexpr()
|
|
{
|
|
int a1[4] = {1, 2, 3, 4};
|
|
const int (&c_a1)[4] = a1;
|
|
std::array<int, 4> a2 = {1, 2, 3, 4};
|
|
const std::array<int, 4>& c_a2 = a2;
|
|
|
|
for (int i = 0; i < 4; ++i)
|
|
{
|
|
if (&gsl::at(a1, i) != &a1[i]) return false;
|
|
if (&gsl::at(c_a1, i) != &a1[i]) return false;
|
|
// requires C++17:
|
|
// if (&gsl::at(a2, i) != &a2[static_cast<std::size_t>(i)]) return false;
|
|
if (&gsl::at(c_a2, i) != &c_a2[static_cast<std::size_t>(i)]) return false;
|
|
if (gsl::at({1, 2, 3, 4}, i) != i + 1) return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
static_assert(test_constexpr(), "FAIL");
|
|
#endif
|