From 092e1569a735b790ec51bf833374d8c60edfdea1 Mon Sep 17 00:00:00 2001 From: Mateusz Pusz Date: Tue, 1 Aug 2023 12:36:27 +0200 Subject: [PATCH] feat: `heat` is now a quantity of `energy` kind ISO 8000-1 says: "The quantities heat, kinetic energy, and potential energy are generally considered to be quantities of the same kind, namely, of the kind of quantity called energy." --- src/systems/isq/include/mp-units/systems/isq/thermodynamics.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systems/isq/include/mp-units/systems/isq/thermodynamics.h b/src/systems/isq/include/mp-units/systems/isq/thermodynamics.h index 24e9ce8d..4e3ab556 100644 --- a/src/systems/isq/include/mp-units/systems/isq/thermodynamics.h +++ b/src/systems/isq/include/mp-units/systems/isq/thermodynamics.h @@ -37,7 +37,7 @@ QUANTITY_SPEC(pressure_coefficient, pressure / thermodynamic_temperature); QUANTITY_SPEC(isothermal_compressibility, 1 / volume * (volume / pressure)); // TODO how to handle "negative" part QUANTITY_SPEC(isentropic_compressibility, 1 / volume * (volume / pressure)); // TODO how to handle "negative" part // energy definition moved to mechanics -QUANTITY_SPEC(heat, mass* pow<2>(length) / pow<2>(time)); // TODO what is a correct equation here? +QUANTITY_SPEC(heat, energy); inline constexpr auto amount_of_heat = heat; QUANTITY_SPEC(latent_heat, heat); // TODO what is a correct equation here? QUANTITY_SPEC(heat_flow_rate, heat / time);