From 15922b5bd86937ca6fd5eadc1313d0e4dc60d4b3 Mon Sep 17 00:00:00 2001
From: Mateusz Pusz <mateusz.pusz@gmail.com>
Date: Fri, 20 Oct 2023 09:39:24 +0200
Subject: [PATCH] fix: `CommonlyInvocableQuantities` was overconstrained for
 the current library design

---
 src/core/include/mp-units/quantity.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/core/include/mp-units/quantity.h b/src/core/include/mp-units/quantity.h
index e845dcce..097dd62a 100644
--- a/src/core/include/mp-units/quantity.h
+++ b/src/core/include/mp-units/quantity.h
@@ -68,9 +68,11 @@ concept InvocableQuantities =
 
 template<typename Func, typename Q1, typename Q2>
 concept CommonlyInvocableQuantities =
-  Quantity<Q1> && Quantity<Q2> && (Q1::quantity_spec.character == Q2::quantity_spec.character) && requires {
-    common_reference(Q1::reference, Q2::reference);
-  } && InvocableQuantities<Func, Q1, Q2, common_quantity_spec(Q1::quantity_spec, Q2::quantity_spec).character>;
+  Quantity<Q1> && Quantity<Q2> &&
+  // (Q1::quantity_spec.character == Q2::quantity_spec.character) && // TODO enable when vector quantities are handled
+  // correctly
+  requires { common_reference(Q1::reference, Q2::reference); } &&
+  InvocableQuantities<Func, Q1, Q2, common_quantity_spec(Q1::quantity_spec, Q2::quantity_spec).character>;
 
 
 template<typename Func, Quantity Q1, Quantity Q2>