From c8421156046024b5ce630bfbb7e5ed0b13797864 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Johel=20Ernesto=20Guerrero=20Pe=C3=B1a?=
 <johelegp@gmail.com>
Date: Wed, 9 Sep 2020 01:52:15 -0400
Subject: [PATCH 1/5] test: dimensionless common type

---
 test/unit_test/static/quantity_test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/test/unit_test/static/quantity_test.cpp b/test/unit_test/static/quantity_test.cpp
index db046b65..3486c165 100644
--- a/test/unit_test/static/quantity_test.cpp
+++ b/test/unit_test/static/quantity_test.cpp
@@ -265,6 +265,10 @@ static_assert(std::equality_comparable<decltype(1q_m)>);
 static_assert(std::equality_comparable_with<decltype(1q_m), decltype(1q_cm)>);
 static_assert(0q_m == 0q_ft_us);
 static_assert(std::equality_comparable_with<decltype(1q_m), decltype(1q_ft_us)>);
+static_assert(std::equality_comparable_with<dimensionless<unitless>, int>);
+static_assert(std::equality_comparable_with<dimensionless<unitless>, double>);
+static_assert(std::equality_comparable_with<dimensionless<unitless, int>, int>);
+static_assert(!std::equality_comparable_with<dimensionless<unitless, int>, double>);
 
 // quantity_cast
 

From 9a130d9b5b6ab1893fd83a89718b17d441600974 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Johel=20Ernesto=20Guerrero=20Pe=C3=B1a?=
 <johelegp@gmail.com>
Date: Wed, 9 Sep 2020 01:52:40 -0400
Subject: [PATCH 2/5] test: percent to unitless conversion

---
 test/unit_test/static/quantity_test.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/unit_test/static/quantity_test.cpp b/test/unit_test/static/quantity_test.cpp
index 3486c165..c267c50f 100644
--- a/test/unit_test/static/quantity_test.cpp
+++ b/test/unit_test/static/quantity_test.cpp
@@ -313,6 +313,7 @@ static_assert(std::is_same_v<decltype(10q_km / 5q_km), quantity<dim_one, unitles
 static_assert(quantity_cast<percent>(50.q_m / 100.q_m).count() == 50);
 static_assert(50.q_m / 100.q_m == dimensionless<percent>(50));
 
+static_assert(dimensionless<unitless>(dimensionless<percent>(50)).count() == 0.5);
 
 // time
 

From 2853a20c7f3afad08992e72580d4774da86ebc12 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Johel=20Ernesto=20Guerrero=20Pe=C3=B1a?=
 <johelegp@gmail.com>
Date: Wed, 9 Sep 2020 02:21:50 -0400
Subject: [PATCH 3/5] style: remove empty parameter list

---
 test/unit_test/static/quantity_test.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/unit_test/static/quantity_test.cpp b/test/unit_test/static/quantity_test.cpp
index c267c50f..b49dc113 100644
--- a/test/unit_test/static/quantity_test.cpp
+++ b/test/unit_test/static/quantity_test.cpp
@@ -299,7 +299,7 @@ static_assert(dimensionless<unitless>(1) + 1 == 2);
 static_assert(dimensionless<unitless, int>(1) + 1 == 2);
 
 template<typename Rep>
-concept invalid_dimensionless_operation = requires()
+concept invalid_dimensionless_operation = requires
 {
     !requires(dimensionless<unitless, Rep> d) { d + 1.23; };
     !requires(dimensionless<unitless, Rep> d) { 1.23 + d; };

From ce583d40e00157236f387b0c1e2f9557a5fe0af6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Johel=20Ernesto=20Guerrero=20Pe=C3=B1a?=
 <johelegp@gmail.com>
Date: Wed, 9 Sep 2020 02:22:34 -0400
Subject: [PATCH 4/5] style: name parameter after what's being tested

---
 test/unit_test/static/quantity_test.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/test/unit_test/static/quantity_test.cpp b/test/unit_test/static/quantity_test.cpp
index b49dc113..8741c3a9 100644
--- a/test/unit_test/static/quantity_test.cpp
+++ b/test/unit_test/static/quantity_test.cpp
@@ -298,13 +298,13 @@ static_assert(1.23 + dimensionless<unitless>(1.23) == 2.46);
 static_assert(dimensionless<unitless>(1) + 1 == 2);
 static_assert(dimensionless<unitless, int>(1) + 1 == 2);
 
-template<typename Rep>
+template<typename Int>
 concept invalid_dimensionless_operation = requires
 {
-    !requires(dimensionless<unitless, Rep> d) { d + 1.23; };
-    !requires(dimensionless<unitless, Rep> d) { 1.23 + d; };
-    !requires(dimensionless<scaled_unit<ratio(1, 1, 1), unitless>, Rep> d) { 1 + d; };
-    !requires(dimensionless<scaled_unit<ratio(1, 1, 1), unitless>, Rep> d) { d + 1; };
+    !requires(dimensionless<unitless, Int> d) { d + 1.23; };
+    !requires(dimensionless<unitless, Int> d) { 1.23 + d; };
+    !requires(dimensionless<scaled_unit<ratio(1, 1, 1), unitless>, Int> d) { 1 + d; };
+    !requires(dimensionless<scaled_unit<ratio(1, 1, 1), unitless>, Int> d) { d + 1; };
 };
 static_assert(invalid_dimensionless_operation<int>);
 

From 749684c8ee872956d74e596295c5869972bd11d5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Johel=20Ernesto=20Guerrero=20Pe=C3=B1a?=
 <johelegp@gmail.com>
Date: Wed, 9 Sep 2020 02:23:49 -0400
Subject: [PATCH 5/5] style: fix name numbering

---
 test/unit_test/static/quantity_test.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/unit_test/static/quantity_test.cpp b/test/unit_test/static/quantity_test.cpp
index 8741c3a9..882252ec 100644
--- a/test/unit_test/static/quantity_test.cpp
+++ b/test/unit_test/static/quantity_test.cpp
@@ -299,14 +299,14 @@ static_assert(dimensionless<unitless>(1) + 1 == 2);
 static_assert(dimensionless<unitless, int>(1) + 1 == 2);
 
 template<typename Int>
-concept invalid_dimensionless_operation = requires
+concept invalid_dimensionless_operations = requires
 {
     !requires(dimensionless<unitless, Int> d) { d + 1.23; };
     !requires(dimensionless<unitless, Int> d) { 1.23 + d; };
     !requires(dimensionless<scaled_unit<ratio(1, 1, 1), unitless>, Int> d) { 1 + d; };
     !requires(dimensionless<scaled_unit<ratio(1, 1, 1), unitless>, Int> d) { d + 1; };
 };
-static_assert(invalid_dimensionless_operation<int>);
+static_assert(invalid_dimensionless_operations<int>);
 
 static_assert(std::is_same_v<decltype(10q_km / 5q_km), quantity<dim_one, unitless, std::int64_t>>);