mpusz/mp-units
1
0
Fork 1
mirror of https://github.com/mpusz/mp-units.git synced 2025-08-03 20:34:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: unit comparison functions optimized for the case of the same unit type

Browse Source
This commit is contained in:
Mateusz Pusz
2024-06-06 20:59:41 +02:00
parent e38c7c4460
commit 3353f492ad
1 changed files with 23 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/core/include/mp-units/framework/unit.h
View File

@@ -500,11 +500,16 @@ MP_UNITS_EXPORT_END
namespace detail { namespace detail {
[[nodiscard]] consteval auto have_same_canonical_reference_unit(Unit auto u1, Unit auto u2) template<Unit U1, Unit U2>
[[nodiscard]] consteval auto have_same_canonical_reference_unit(U1 u1, U2 u2)
{ {
if constexpr (is_same_v<U1, U2>)
return std::true_type{};
else {
using canonical_lhs = decltype(get_canonical_unit(u1)); using canonical_lhs = decltype(get_canonical_unit(u1));
using canonical_rhs = decltype(get_canonical_unit(u2)); using canonical_rhs = decltype(get_canonical_unit(u2));
return std::is_same<decltype(canonical_lhs::reference_unit), decltype(canonical_rhs::reference_unit)>{}; return std::is_same<decltype(canonical_lhs::reference_unit), decltype(canonical_rhs::reference_unit)>{};
}
} }
} // namespace detail } // namespace detail
@@ -513,6 +518,9 @@ namespace detail {
MP_UNITS_EXPORT template<Unit U1, Unit U2> MP_UNITS_EXPORT template<Unit U1, Unit U2>
[[nodiscard]] consteval bool operator==(U1 lhs, U2 rhs) [[nodiscard]] consteval bool operator==(U1 lhs, U2 rhs)
{ {
if constexpr (is_same_v<U1, U2>)
return true;
else
return decltype(detail::have_same_canonical_reference_unit(lhs, rhs))::value && return decltype(detail::have_same_canonical_reference_unit(lhs, rhs))::value &&
decltype(get_canonical_unit(lhs))::mag == decltype(get_canonical_unit(rhs))::mag; decltype(get_canonical_unit(lhs))::mag == decltype(get_canonical_unit(rhs))::mag;
} }
@@ -603,8 +611,12 @@ inline constexpr auto ppm = parts_per_million;
// convertible_to // convertible_to
[[nodiscard]] consteval bool convertible(Unit auto from, Unit auto to) template<Unit U1, Unit U2>
[[nodiscard]] consteval bool convertible(U1 from, U2 to)
{ {
if constexpr (is_same_v<U1, U2>)
return true;
else
return decltype(detail::have_same_canonical_reference_unit(from, to))::value; return decltype(detail::have_same_canonical_reference_unit(from, to))::value;
} }
@@ -615,7 +627,9 @@ template<Unit U1, Unit U2>
[[nodiscard]] consteval Unit auto common_unit(U1 u1, U2 u2) [[nodiscard]] consteval Unit auto common_unit(U1 u1, U2 u2)
requires(decltype(detail::have_same_canonical_reference_unit(u1, u2))::value) requires(decltype(detail::have_same_canonical_reference_unit(u1, u2))::value)
{ {
if constexpr (U1{} == U2{}) { if constexpr (is_same_v<U1, U2>)
return u1;
else if constexpr (U1{} == U2{}) {
if constexpr (std::derived_from<U1, typename U2::_base_type_>) if constexpr (std::derived_from<U1, typename U2::_base_type_>)
return u1; return u1;
else if constexpr (std::derived_from<U2, typename U1::_base_type_>) else if constexpr (std::derived_from<U2, typename U1::_base_type_>)