diff --git a/src/core/include/mp-units/framework/quantity_point.h b/src/core/include/mp-units/framework/quantity_point.h index 8079d5d1..4a74a97e 100644 --- a/src/core/include/mp-units/framework/quantity_point.h +++ b/src/core/include/mp-units/framework/quantity_point.h @@ -51,17 +51,24 @@ template return is_specialization_of_zeroth_point_origin; } +template Q = std::remove_cvref_t> +[[nodiscard]] constexpr QuantityPoint auto make_quantity_point(FwdQ&& q, PO po) +{ + if constexpr (detail::is_zeroth_point_origin(PO{})) + return quantity_point{std::forward(q)}; + else + return quantity_point{std::forward(q), po}; +} + struct point_origin_interface { template Q = std::remove_cvref_t> - [[nodiscard]] friend constexpr quantity_point - operator+(PO, FwdQ&& q) + [[nodiscard]] friend constexpr QuantityPoint auto operator+(PO po, FwdQ&& q) { - return quantity_point{std::forward(q), PO{}}; + return quantity_point{std::forward(q), po}; } template Q = std::remove_cvref_t> - [[nodiscard]] friend constexpr quantity_point - operator+(FwdQ&& q, PO po) + [[nodiscard]] friend constexpr QuantityPoint auto operator+(FwdQ&& q, PO po) { return po + std::forward(q); } @@ -264,7 +271,7 @@ public: template NewPO> [[nodiscard]] constexpr QuantityPointOf<(NewPO{})> auto point_for(NewPO new_origin) const { - if constexpr (is_same_v) + if constexpr (is_same_v) return *this; else return ::mp_units::quantity_point{*this - new_origin, new_origin}; @@ -456,10 +463,7 @@ public: [[nodiscard]] friend constexpr QuantityPoint auto operator+(const QP& qp, const quantity& q) requires requires { qp.quantity_ref_from(PO) + q; } { - if constexpr (detail::is_zeroth_point_origin(PO)) - return ::mp_units::quantity_point{qp.quantity_ref_from(PO) + q}; - else - return ::mp_units::quantity_point{qp.quantity_ref_from(PO) + q, PO}; + return detail::make_quantity_point(qp.quantity_ref_from(PO) + q, PO); } template QP> @@ -477,10 +481,7 @@ public: [[nodiscard]] friend constexpr QuantityPoint auto operator-(const QP& qp, const quantity& q) requires requires { qp.quantity_ref_from(PO) - q; } { - if constexpr (detail::is_zeroth_point_origin(PO)) - return ::mp_units::quantity_point{qp.quantity_ref_from(PO) - q}; - else - return ::mp_units::quantity_point{qp.quantity_ref_from(PO) - q, PO}; + return detail::make_quantity_point(qp.quantity_ref_from(PO) - q, PO); } template QP, QuantityPointOf QP2> diff --git a/src/core/include/mp-units/math.h b/src/core/include/mp-units/math.h index 86a412aa..420472db 100644 --- a/src/core/include/mp-units/math.h +++ b/src/core/include/mp-units/math.h @@ -444,13 +444,17 @@ template * @brief Computes the inverse of a quantity in a provided unit */ template -[[nodiscard]] constexpr QuantityOf auto inverse(const quantity& q) +[[nodiscard]] constexpr Quantity auto inverse(const quantity& q) requires requires { representation_values::one(); value_cast(representation_values::one() / q); } { - return (representation_values::one() * one).force_in(To * quantity::unit) / q; + if constexpr (AssociatedUnit) { + constexpr QuantitySpec auto qs = get_quantity_spec(To) * quantity::quantity_spec; + return qs(representation_values::one() * one).force_in(To * quantity::unit) / q; + } else + return (representation_values::one() * one).force_in(To * quantity::unit) / q; } /**